-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
doc,deps: document how to maintain ICU in Node.js
- update v8 guide to mention ICU - move content from the tools/icu/README.md but leave a pointer Fixes: #26108 Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: #30607 Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
- Loading branch information
1 parent
7f94fe0
commit f36331c
Showing
3 changed files
with
255 additions
and
115 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,233 @@ | ||
| # Maintaining ICU in Node.js | ||
|
|
||
| ## Background | ||
|
|
||
| International Components for Unicode ([ICU4C][ICU]) is used both by V8 | ||
| and also by Node.js directly to provide internationalization | ||
| functionality. To quote from icu-project.org: | ||
|
|
||
| > ICU is a mature, widely used set of C/C++ and Java libraries providing | ||
| > Unicode and Globalization support for software applications. ICU is | ||
| > widely portable and gives applications the same results on all platforms | ||
| > and between C/C++ and Java software. | ||
| ## Data dependencies | ||
|
|
||
| ICU consumes and includes: | ||
|
|
||
| * Extracted locale data from [CLDR][] | ||
| * Extracted [Unicode][] data. | ||
| * Time zone ([tz][]) data | ||
|
|
||
| The current versions of these items can be viewed for node with `node -p process.versions`: | ||
|
|
||
| ```shell | ||
| $ node -p process.versions | ||
|
|
||
| { | ||
| … | ||
| cldr: '35.1', | ||
| icu: '64.2', | ||
| tz: '2019a', | ||
| unicode: '12.1' | ||
| } | ||
| ``` | ||
|
|
||
| ## Release Schedule | ||
|
|
||
| ICU typically has >1 release a year, particularly coinciding with a major | ||
| release of [Unicode][]. The current release schedule is available on the [ICU][] | ||
| website on the left sidebar. | ||
|
|
||
| ### V8 depends on ICU | ||
|
|
||
| V8 will aggressively upgrade to a new ICU version, due to requirements for | ||
| features/bugfixes needed for [Ecma402][] support. The minimum required version | ||
| of ICU is specified within the V8 source tree. If the ICU version is too old, | ||
| V8 will not compile. | ||
|
|
||
| ```c | ||
| // deps/v8/src/objects/intl-objects.h | ||
| #define V8_MINIMUM_ICU_VERSION 64 | ||
| ``` | ||
| V8 in Node.js depends on the ICU version supplied by Node.js. | ||
| The file `tools/icu/icu_versions.json` contains the current minimum | ||
| version of ICU that Node.js is known to work with. This should be | ||
| _at least_ the same version as V8, so that users will find out | ||
| earlier that their ICU is too old. A test case validates this when | ||
| Node.js is built. | ||
| ## How to upgrade ICU | ||
| * Make sure your Node.js workspace is clean (`git status` | ||
| should be sufficient). | ||
| * Configure Node.js with the specific [ICU version](http://icu-project.org/download) | ||
| you want to upgrade to, for example: | ||
| ```shell | ||
| ./configure \ | ||
| --with-intl=full-icu \ | ||
| --with-icu-source=http://download.icu-project.org/files/icu4c/58.1/icu4c-58_1-src.tgz | ||
| make | ||
| ``` | ||
|
|
||
| > _Note_ in theory, the equivalent `vcbuild.bat` commands should work also, | ||
| > but the commands below are makefile-centric. | ||
|
|
||
| * If there are ICU version-specific changes needed, you may need to make changes | ||
| in `tools/icu/icu-generic.gyp` or add patch files to `tools/icu/patches`. | ||
| * Specifically, look for the lists in `sources!` in the `tools/icu/icu-generic.gyp` for | ||
| files to exclude. | ||
|
|
||
| * Verify the Node.js build works: | ||
|
|
||
| ```shell | ||
| make test-ci | ||
| ``` | ||
|
|
||
| Also running | ||
|
|
||
| <!-- eslint-disable strict --> | ||
|
|
||
| ```js | ||
| new Intl.DateTimeFormat('es', { month: 'long' }).format(new Date(9E8)); | ||
| ``` | ||
|
|
||
| …Should return `enero` not `January`. | ||
|
|
||
| * Now, copy `deps/icu` over to `deps/icu-small` | ||
|
|
||
| > :warning: Do not modify any source code in `deps/icu-small` ! | ||
| > See section below about floating patches to ICU. | ||
| ```shell | ||
| python tools/icu/shrink-icu-src.py | ||
| ``` | ||
|
|
||
| * Now, do a clean rebuild of Node.js to test: | ||
|
|
||
| ```shell | ||
| make -k distclean | ||
| ./configure | ||
| make | ||
| ``` | ||
|
|
||
| * Test this newly default-generated Node.js | ||
|
|
||
| <!-- eslint-disable strict --> | ||
|
|
||
| ```js | ||
| process.versions.icu; | ||
| new Intl.DateTimeFormat('es', { month: 'long' }).format(new Date(9E8)); | ||
| ``` | ||
|
|
||
| (This should print your updated ICU version number, and also `January` again.) | ||
|
|
||
| You are ready to check in the updated `deps/icu-small`. This is a big commit, | ||
| so make this a separate commit from the smaller changes. | ||
|
|
||
| > :warning: Do not modify any source code in `deps/icu-small` ! | ||
| > See section below about floating patches to ICU. | ||
| * Now, rebuild the Node.js license. | ||
|
|
||
| ```shell | ||
| # clean up - remove deps/icu | ||
| make clean | ||
| tools/license-builder.sh | ||
| ``` | ||
|
|
||
| * Update the URL and hash for the full ICU file in `tools/icu/current_ver.dep`. | ||
| It should match the ICU URL used in the first step. When this is done, the | ||
| following should build with small ICU. | ||
|
|
||
| ```shell | ||
| # clean up | ||
| rm -rf out deps/icu deps/icu4c* | ||
| ./configure --with-intl=small-icu --download=all | ||
| make | ||
| make test-ci | ||
| ``` | ||
|
|
||
| * commit the change to `tools/icu/current_ver.dep` and `LICENSE` files. | ||
|
|
||
| * Note: To simplify review, I often will “pre-land” this patch, meaning that | ||
| I run the patch through `curl -L https://github.com/nodejs/node/pull/xxx.patch | ||
| | git am -3 --whitespace=fix` per the collaborator’s guide… and then push that | ||
| patched branch into my PR's branch. This reduces the whitespace changes that | ||
| show up in the PR, since the final land will eliminate those anyway. | ||
|
|
||
| ## Floating patches to ICU | ||
|
|
||
| Floating patches are applied at `configure` time. The "patch" files | ||
| are used instead of the original source files. The patch files are | ||
| complete `.cpp` files replacing the original contents. | ||
|
|
||
| Patches are tied to a specific ICU version. They won’t apply to a | ||
| future ICU version. We assume that you filed a bug against [ICU][] and | ||
| upstreamed the fix, so the patch won’t be needed in a later ICU | ||
| version. | ||
|
|
||
| ### Example | ||
|
|
||
| For example, to patch `source/tools/toolutil/pkg_genc.cpp` for | ||
| ICU version 63: | ||
|
|
||
| ```shell | ||
| # go to your Node.js source directory | ||
| cd <node> | ||
|
|
||
| # create the floating patch directory | ||
| mkdir -p tools/icu/patches/63 | ||
|
|
||
| # create the subdirectory for the file(s) to patch: | ||
| mkdir -p tools/icu/patches/63/source/tools/toolutil/ | ||
|
|
||
| # copy the file to patch | ||
| cp deps/icu-small/source/tools/toolutil/pkg_genc.cpp \ | ||
| tools/icu/patches/63/source/tools/toolutil/pkg_genc.cpp | ||
|
|
||
| # Make any changes to this file: | ||
| (edit tools/icu/patches/63/source/tools/toolutil/pkg_genc.cpp ) | ||
|
|
||
| # test | ||
| make clean && ./configure && make | ||
| ``` | ||
|
|
||
| You should see a message such as: | ||
|
|
||
| ```shell | ||
| INFO: Using floating patch "tools/icu/patches/63/source/tools/toolutil/pkg_genc.cpp" from "tools/icu" | ||
| ``` | ||
|
|
||
| ### Clean Up | ||
|
|
||
| Any patches older than the minimum version given in `tools/icu/icu_versions.json` | ||
| ought to be deleted, because they will never be used. | ||
|
|
||
| ### Why not just modify the ICU source directly? | ||
|
|
||
| Especially given the V8 dependencies above, there may be times when a floating | ||
| patch to ICU is required. Though it seems expedient to simply change a file in | ||
| `deps/icu-small`, this is not the right approach for the following reasons: | ||
|
|
||
| 1. **Repeatability.** Given the complexity of merging in a new ICU version, | ||
| following the steps above in the prior section of this document ought to be | ||
| repeatable without concern for overriding a patch. | ||
|
|
||
| 2. **Verifiability.** Given the number of files modified in an ICU PR, | ||
| a floating patch could easily be missed — or dropped altogether next time | ||
| something is landed. | ||
|
|
||
| 3. **Compatibility.** There are a number of ways that ICU can be loaded into | ||
| Node.js (see the top level README.md). Only modifying `icu-small` would cause | ||
| the patch not to be landed in case the user specifies the ICU source code | ||
| another way. | ||
|
|
||
| [ICU]: http://icu-project.org | ||
| [Unicode]: https://unicode.org | ||
| [tz]: https://www.iana.org/time-zones | ||
| [CLDR]: https://unicode.org/cldr | ||
| [Ecma402]: https://github.com/tc39/ecma402 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters