Skip to content

Commit f2fb414

Browse files
TrottMylesBorins
authored andcommitted
test: refactor test-dgram-membership
* match full error message in assert.throws() * wrapped function -> .bind() PR-URL: #11388 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 8f49962 commit f2fb414

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

test/parallel/test-dgram-membership.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@ const assert = require('assert');
55
const dgram = require('dgram');
66
const multicastAddress = '224.0.0.114';
77

8-
const setup = () => {
9-
return dgram.createSocket({type: 'udp4', reuseAddr: true});
10-
};
8+
const setup = dgram.createSocket.bind(dgram, {type: 'udp4', reuseAddr: true});
119

1210
// addMembership() on closed socket should throw
1311
{
@@ -46,14 +44,16 @@ const setup = () => {
4644
// addMembership() with invalid multicast address should throw
4745
{
4846
const socket = setup();
49-
assert.throws(() => { socket.addMembership('256.256.256.256'); }, /EINVAL/);
47+
assert.throws(() => { socket.addMembership('256.256.256.256'); },
48+
/^Error: addMembership EINVAL$/);
5049
socket.close();
5150
}
5251

5352
// dropMembership() with invalid multicast address should throw
5453
{
5554
const socket = setup();
56-
assert.throws(() => { socket.dropMembership('256.256.256.256'); }, /EINVAL/);
55+
assert.throws(() => { socket.dropMembership('256.256.256.256'); },
56+
/^Error: dropMembership EINVAL$/);
5757
socket.close();
5858
}
5959

0 commit comments

Comments
 (0)