cleanup test-* files

panva · panva · commit f0ec5df26113 · 2023-02-22T11:53:40.000+01:00
diff --git a/test/common/wpt.js b/test/common/wpt.js
@@ -489,9 +489,7 @@ class WPTRunner {
   pretendGlobalThisAs(name) {
     switch (name) {
       case 'Window': {
-        this.globalThisInitScripts.push(
-          `global.Window = Object.getPrototypeOf(globalThis).constructor;
-          self.GLOBAL.isWorker = () => false;`);
+        this.globalThisInitScripts.push('globalThis.Window = Object.getPrototypeOf(globalThis).constructor;');
         this.loadLazyGlobals();
         break;
       }
@@ -531,39 +529,10 @@ class WPTRunner {
     this.globalThisInitScripts.push(script);
   }
 
-  brandCheckGlobalScopeAttribute(name) {
-    // TODO(legendecas): idlharness GlobalScope attribute receiver validation.
-    const script = `
-      const desc = Object.getOwnPropertyDescriptor(globalThis, '${name}');
-      function getter() {
-        // Mimic GlobalScope instance brand check.
-        if (this !== globalThis) {
-          throw new TypeError('Illegal invocation');
-        }
-        return desc.get();
-      }
-      Object.defineProperty(getter, 'name', { value: 'get ${name}' });
-
-      function setter(value) {
-        // Mimic GlobalScope instance brand check.
-        if (this !== globalThis) {
-          throw new TypeError('Illegal invocation');
-        }
-        desc.set(value);
-      }
-      Object.defineProperty(setter, 'name', { value: 'set ${name}' });
-
-      Object.defineProperty(globalThis, '${name}', {
-        get: getter,
-        set: setter,
-      });
-    `;
-    this.globalThisInitScripts.push(script);
-  }
-
   // TODO(joyeecheung): work with the upstream to port more tests in .html
   // to .js.
   async runJsTests() {
+    this.pretendGlobalThisAs('Window');
     let queue = [];
 
     // If the tests are run as `node test/wpt/test-something.js subset.any.js`,
diff --git a/test/wpt/.eslintrc.yaml b/test/wpt/.eslintrc.yaml
@@ -0,0 +1,3 @@
+rules:
+  node-core/required-modules: off
+  node-core/require-common-first: off
diff --git a/test/wpt/status/FileAPI/blob.json b/test/wpt/status/FileAPI/blob.json
@@ -17,6 +17,7 @@
         "ArrayBuffer elements of the blobParts array should be supported.",
         "Passing typed arrays as elements of the blobParts array should work.",
         "Passing a Float64Array as element of the blobParts array should work.",
+        "Passing BigInt typed arrays as elements of the blobParts array should work.",
         "Array with two blobs",
         "Array with two buffers",
         "Array with two bufferviews",
@@ -43,5 +44,12 @@
   },
   "Blob-slice.any.js": {
     "skip": "Depends on File API"
+  },
+  "Blob-stream.any.js": {
+    "fail": {
+      "expected": [
+        "Reading Blob.stream() with BYOB reader"
+      ]
+    }
   }
 }
diff --git a/test/wpt/status/dom/events.json b/test/wpt/status/dom/events.json
@@ -23,9 +23,6 @@
   "event-global-set-before-handleEvent-lookup.window.js": {
     "skip": "window is not defined"
   },
-  "event-global.worker.js": {
-    "skip": "importScripts is not defined"
-  },
   "legacy-pre-activation-behavior.window.js": {
     "skip": "document is not defined"
   },
diff --git a/test/wpt/status/encoding.json b/test/wpt/status/encoding.json
@@ -51,6 +51,9 @@
   "streams/realms.window.js": {
     "skip": "window is not defined"
   },
+  "streams/invalid-realm.window.js": {
+    "skip": "document is not defined"
+  },
   "streams/decode-attributes.any.js": {
     "requires": ["full-icu"]
   },
diff --git a/test/wpt/status/hr-time.json b/test/wpt/status/hr-time.json
@@ -1,4 +1,11 @@
 {
+  "idlharness.any.js": {
+    "fail": {
+      "expected": [
+        "Window interface: attribute performance"
+      ]
+    }
+  },
   "window-worker-timeOrigin.window.js": {
     "skip": "depends on URL.createObjectURL(blob)"
   }
diff --git a/test/wpt/status/html/webappapis/structured-clone.json b/test/wpt/status/html/webappapis/structured-clone.json
@@ -1,7 +1,24 @@
 {
   "structured-clone.any.js": {
     "fail": {
-      "expected": ["File basic"]
+      "expected": [
+        "File basic",
+        "Serializing a non-serializable platform object fails",
+        "A subclass instance will deserialize as its closest serializable superclass",
+        "Resizable ArrayBuffer",
+        "Growable SharedArrayBuffer",
+        "Length-tracking TypedArray",
+        "Length-tracking DataView",
+        "Serializing OOB TypedArray throws",
+        "Serializing OOB DataView throws",
+        "A detached ArrayBuffer cannot be transferred",
+        "Transferring a non-transferable platform object fails",
+        "Resizable ArrayBuffer is transferable",
+        "Length-tracking TypedArray is transferable",
+        "Length-tracking DataView is transferable",
+        "Transferring OOB TypedArray throws",
+        "Transferring OOB DataView throws"
+      ]
     }
   }
 }
diff --git a/test/wpt/status/html/webappapis/timers.json b/test/wpt/status/html/webappapis/timers.json
@@ -1,4 +1,7 @@
 {
+  "evil-spec-example.any.js": {
+    "skip": "Node.js validates setTimeout arguments using its own validators, not WebIDL"
+  },
   "negative-settimeout.any.js": {
     "skip": "unreliable in Node.js; Refs: https://github.com/nodejs/node/issues/37672"
   }
diff --git a/test/wpt/status/performance-timeline.json b/test/wpt/status/performance-timeline.json
@@ -7,6 +7,9 @@
       ]
     }
   },
+  "droppedentriescount.any.js": {
+    "skip": "depends on relative-path fetch()"
+  },
   "webtiming-resolution.any.js": {
     "skip": "flaky"
   }
diff --git a/test/wpt/status/resource-timing.json b/test/wpt/status/resource-timing.json
@@ -1,4 +1,15 @@
 {
+  "idlharness.any.js": {
+    "fail": {
+      "expected": [
+        "PerformanceResourceTiming interface: attribute responseStatus",
+        "PerformanceResourceTiming interface: attribute renderBlockingStatus",
+        "PerformanceResourceTiming interface: resource must inherit property \"responseStatus\" with the proper type",
+        "PerformanceResourceTiming interface: resource must inherit property \"renderBlockingStatus\" with the proper type",
+        "PerformanceResourceTiming interface: default toJSON operation on resource"
+      ]
+    }
+  },
   "cors-preflight.any.js": {
     "skip": "Browser-specific test"
   },
diff --git a/test/wpt/status/streams.json b/test/wpt/status/streams.json
@@ -1,4 +1,12 @@
 {
+  "idlharness.any.js": {
+    "fail": {
+      "note": "enumerable expected true but got false",
+      "expected": [
+        "ReadableStream interface: async iterable<any>"
+      ]
+    }
+  },
   "queuing-strategies-size-function-per-global.window.js": {
     "skip": "Browser-specific test"
   },
diff --git a/test/wpt/status/url.json b/test/wpt/status/url.json
@@ -25,7 +25,12 @@
     "requires": ["small-icu"]
   },
   "url-setters.any.js": {
-    "requires": ["small-icu"]
+    "requires": ["small-icu"],
+    "fail": {
+      "expected": [
+        "URL: Setting <http://example.net:8080/path>.port = 'randomstring' Setting port to a string that doesn't parse as a number"
+      ]
+    }
   },
   "url-setters-a-area.window.js": {
     "skip": "already tested in url-setters.any.js"
diff --git a/test/wpt/status/user-timing.json b/test/wpt/status/user-timing.json
@@ -1,8 +1 @@
-{
-  "invoke_with_timing_attributes.worker.js": {
-    "skip": "importScripts not supported"
-  },
-  "performance-measure-invalid.worker.js": {
-    "skip": "importScripts not supported"
-  }
-}
+{}
diff --git a/test/wpt/status/webidl/ecmascript-binding/es-exceptions.json b/test/wpt/status/webidl/ecmascript-binding/es-exceptions.json
@@ -1 +1,9 @@
-{}
+{
+  "DOMException-constructor-and-prototype.any.js": {
+    "fail": {
+      "expected": [
+        "existence and property descriptor of DOMException"
+      ]
+    }
+  }
+}
diff --git a/test/wpt/test-abort.js b/test/wpt/test-abort.js
@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+
 const { WPTRunner } = require('../common/wpt');
 
 const runner = new WPTRunner('dom/abort');
diff --git a/test/wpt/test-atob.js b/test/wpt/test-atob.js
@@ -1,6 +1,5 @@
 'use strict';
 
-require('../common');
 const { WPTRunner } = require('../common/wpt');
 
 const runner = new WPTRunner('html/webappapis/atob');
diff --git a/test/wpt/test-blob.js b/test/wpt/test-blob.js
@@ -1,15 +1,7 @@
 'use strict';
 
-require('../common');
 const { WPTRunner } = require('../common/wpt');
 
 const runner = new WPTRunner('FileAPI/blob');
 
-runner.setInitScript(`
-  const { Blob } = require('buffer');
-  const { ReadableStream } = require('stream/web');
-  global.Blob = Blob;
-  global.ReadableStream = ReadableStream;
-`);
-
 runner.runJsTests();
diff --git a/test/wpt/test-broadcastchannel.js b/test/wpt/test-broadcastchannel.js
@@ -1,13 +1,7 @@
 'use strict';
 
-require('../common');
 const { WPTRunner } = require('../common/wpt');
 
 const runner = new WPTRunner('webmessaging/broadcastchannel');
 
-runner.setInitScript(`
-  const { BroadcastChannel } = require('worker_threads');
-  global.BroadcastChannel = BroadcastChannel;
-`);
-
 runner.runJsTests();
diff --git a/test/wpt/test-console.js b/test/wpt/test-console.js
@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+
 const { WPTRunner } = require('../common/wpt');
 
 const runner = new WPTRunner('console');
diff --git a/test/wpt/test-domexception.js b/test/wpt/test-domexception.js
@@ -1,19 +1,7 @@
 'use strict';
 
-require('../common');
 const { WPTRunner } = require('../common/wpt');
 
 const runner = new WPTRunner('webidl/ecmascript-binding/es-exceptions');
 
-runner.setFlags(['--expose-internals']);
-runner.setInitScript(`
-  const { internalBinding } = require('internal/test/binding');
-  const { DOMException } = internalBinding('messaging');
-  Object.defineProperty(global, 'DOMException', {
-    writable: true,
-    configurable: true,
-    value: DOMException,
-  });
-`);
-
 runner.runJsTests();
diff --git a/test/wpt/test-encoding.js b/test/wpt/test-encoding.js
@@ -1,11 +1,7 @@
 'use strict';
-require('../common');
+
 const { WPTRunner } = require('../common/wpt');
-const runner = new WPTRunner('encoding');
 
-runner.setInitScript(`
-  const { MessageChannel } = require('worker_threads');
-  global.MessageChannel = MessageChannel;
-`);
+const runner = new WPTRunner('encoding');
 
 runner.runJsTests();
diff --git a/test/wpt/test-events.js b/test/wpt/test-events.js
@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+
 const { WPTRunner } = require('../common/wpt');
 
 const runner = new WPTRunner('dom/events');
diff --git a/test/wpt/test-file.js b/test/wpt/test-file.js
@@ -1,6 +1,5 @@
 'use strict';
 
-require('../common');
 const { WPTRunner } = require('../common/wpt');
 
 const runner = new WPTRunner('FileAPI/file');
diff --git a/test/wpt/test-hr-time.js b/test/wpt/test-hr-time.js
@@ -1,11 +1,11 @@
 'use strict';
 
-require('../common');
 const { WPTRunner } = require('../common/wpt');
 
 const runner = new WPTRunner('hr-time');
 
-runner.pretendGlobalThisAs('Window');
-runner.brandCheckGlobalScopeAttribute('performance');
+runner.setInitScript(`
+  self.GLOBAL.isWorker = () => false;
+`);
 
 runner.runJsTests();
diff --git a/test/wpt/test-microtask-queuing.js b/test/wpt/test-microtask-queuing.js
@@ -1,6 +1,5 @@
 'use strict';
 
-require('../common');
 const { WPTRunner } = require('../common/wpt');
 
 const runner = new WPTRunner('html/webappapis/microtask-queuing');
diff --git a/test/wpt/test-performance-timeline.js b/test/wpt/test-performance-timeline.js
@@ -1,11 +1,9 @@
 'use strict';
-require('../common');
+
 const { WPTRunner } = require('../common/wpt');
 
 const runner = new WPTRunner('performance-timeline');
 
-runner.pretendGlobalThisAs('Window');
-runner.brandCheckGlobalScopeAttribute('performance');
 runner.setInitScript(`
   // Create a dummy resource timing entry to mimic how the browser would
   // record the initial page load.
diff --git a/test/wpt/test-resource-timing.js b/test/wpt/test-resource-timing.js
@@ -1,10 +1,9 @@
 'use strict';
-require('../common');
+
 const { WPTRunner } = require('../common/wpt');
 
 const runner = new WPTRunner('resource-timing');
 
-runner.pretendGlobalThisAs('Window');
 runner.setInitScript(`
   global.resource = performance.markResourceTiming({
     startTime: 0,
diff --git a/test/wpt/test-streams.js b/test/wpt/test-streams.js
diff --git a/test/wpt/test-structured-clone.js b/test/wpt/test-structured-clone.js
diff --git a/test/wpt/test-timers.js b/test/wpt/test-timers.js
diff --git a/test/wpt/test-url.js b/test/wpt/test-url.js
diff --git a/test/wpt/test-user-timing.js b/test/wpt/test-user-timing.js
diff --git a/test/wpt/test-wasm-webapi.js b/test/wpt/test-wasm-webapi.js
diff --git a/test/wpt/test-webcrypto.js b/test/wpt/test-webcrypto.js

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+rules:`
	`2`	`+ node-core/required-modules: off`
	`3`	`+ node-core/require-common-first: off`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,11 @@`
`1`	`1`	`{`
	`2`	`+ "idlharness.any.js": {`
	`3`	`+ "fail": {`
	`4`	`+ "expected": [`
	`5`	`+ "Window interface: attribute performance"`
	`6`	`+ ]`
	`7`	`+ }`
	`8`	`+ },`
`2`	`9`	`"window-worker-timeOrigin.window.js": {`
`3`	`10`	`"skip": "depends on URL.createObjectURL(blob)"`
`4`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,7 @@`
`1`	`1`	`{`
	`2`	`+ "evil-spec-example.any.js": {`
	`3`	`+ "skip": "Node.js validates setTimeout arguments using its own validators, not WebIDL"`
	`4`	`+ },`
`2`	`5`	`"negative-settimeout.any.js": {`
`3`	`6`	`"skip": "unreliable in Node.js; Refs: https://github.com/nodejs/node/issues/37672"`
`4`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,9 @@`
`7`	`7`	`]`
`8`	`8`	`}`
`9`	`9`	`},`
	`10`	`+ "droppedentriescount.any.js": {`
	`11`	`+ "skip": "depends on relative-path fetch()"`
	`12`	`+ },`
`10`	`13`	`"webtiming-resolution.any.js": {`
`11`	`14`	`"skip": "flaky"`
`12`	`15`	`}`