test: use Flags comment option to set a localstorage file

Author: danielmbrasil

test/common/index.js

@@ -317,21 +317,7 @@ const knownGlobals = new Set([
  'localStorage',
  'sessionStorage',
 ].forEach((i) => {
-  if (i === 'localStorage') {
-    const getLocalStorage = Object.defineProperty(() => {}, 'name', {
-      value: 'get localStorage',
-    });
-
-    Object.defineProperties(globalThis, {
-      localStorage: {
-        configurable: true,
-        enumerable: true,
-        get: getLocalStorage,
-      },
-    });
-
-    knownGlobals.add(globalThis[i]);
-  } else if (globalThis[i] !== undefined) {
+  if (globalThis[i] !== undefined) {
     knownGlobals.add(globalThis[i]);
   }
 });

test/fixtures/localstoragefile-global-test

@@ -22,6 +22,7 @@
 // This test cannot run in strict mode because it tests that `baseFoo` is
 // treated as a global without being declared with `var`/`let`/`const`.
 
+// Flags: --localstorage-file=./test/fixtures/localstoragefile-global-test
 /* eslint-disable strict */
 const common = require('../common');
 const fixtures = require('../common/fixtures');

test/parallel/test-global.js

@@ -1,4 +1,6 @@
 'use strict';
+
+// Flags: --localstorage-file=./test/fixtures/localstoragefile-global-test
 const { skipIfSQLiteMissing, spawnPromisified } = require('../common');
 skipIfSQLiteMissing();
 const tmpdir = require('../common/tmpdir');