Commit efd297a
deps: fix addons compilation with VS2013
VS2013 does not support defaulting move constructor and assignment
operator. This adds explicit definitions of those methods for two
classes.
This fix is required because we still support building addons with
VS2013 and the incompatibility is in v8.h.
Fixes: nodejs/node-v8#4
Refs: #13263
Backport-PR-URL: #14574
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>
Backport-Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #14004
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 357873d commit efd297a
2 files changed
+23
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4063 | 4063 | | |
4064 | 4064 | | |
4065 | 4065 | | |
4066 | | - | |
| 4066 | + | |
| 4067 | + | |
| 4068 | + | |
4067 | 4069 | | |
4068 | 4070 | | |
4069 | | - | |
| 4071 | + | |
4070 | 4072 | | |
4071 | 4073 | | |
4072 | 4074 | | |
| |||
4139 | 4141 | | |
4140 | 4142 | | |
4141 | 4143 | | |
4142 | | - | |
| 4144 | + | |
| 4145 | + | |
| 4146 | + | |
4143 | 4147 | | |
4144 | | - | |
| 4148 | + | |
4145 | 4149 | | |
4146 | 4150 | | |
4147 | 4151 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7647 | 7647 | | |
7648 | 7648 | | |
7649 | 7649 | | |
| 7650 | + | |
| 7651 | + | |
| 7652 | + | |
| 7653 | + | |
| 7654 | + | |
| 7655 | + | |
| 7656 | + | |
| 7657 | + | |
7650 | 7658 | | |
7651 | 7659 | | |
7652 | 7660 | | |
| |||
7760 | 7768 | | |
7761 | 7769 | | |
7762 | 7770 | | |
| 7771 | + | |
| 7772 | + | |
| 7773 | + | |
| 7774 | + | |
| 7775 | + | |
| 7776 | + | |
| 7777 | + | |
7763 | 7778 | | |
7764 | 7779 | | |
7765 | 7780 | | |
| |||
0 commit comments