Review update. Use the overload of Set()

gla5001 · gla5001 · commit efa8086bb93f · 2017-09-20T21:11:06.000-05:00
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -283,9 +283,10 @@ void ThrowCryptoError(Environment* env,
     if (err_buf) {
       char tmpStr[256] = { };
       ERR_error_string_n(err_buf, tmpStr, sizeof(tmpStr));
-      errorStack->Set(i, String::NewFromUtf8(env->isolate(), tmpStr,
+      errorStack->Set(env->context(), i,
+                      String::NewFromUtf8(env->isolate(), tmpStr,
                                              v8::NewStringType::kNormal)
-                                                .ToLocalChecked());
+                                                .ToLocalChecked()).FromJust();
     }
     es->top -= 1;
   }

Original file line number	Diff line number	Diff line change
`@@ -283,9 +283,10 @@ void ThrowCryptoError(Environment* env,`
`283`	`283`	`if (err_buf) {`
`284`	`284`	`char tmpStr[256] = { };`
`285`	`285`	`ERR_error_string_n(err_buf, tmpStr, sizeof(tmpStr));`
`286`		`- errorStack->Set(i, String::NewFromUtf8(env->isolate(), tmpStr,`
	`286`	`+ errorStack->Set(env->context(), i,`
	`287`	`+ String::NewFromUtf8(env->isolate(), tmpStr,`
`287`	`288`	`v8::NewStringType::kNormal)`
`288`		`- .ToLocalChecked());`
	`289`	`+ .ToLocalChecked()).FromJust();`
`289`	`290`	`}`
`290`	`291`	`es->top -= 1;`
`291`	`292`	`}`