fixup! buffer: add endings option, remove Node.js specific encoding option

Author: jasnell

doc/api/buffer.md

@@ -459,6 +459,11 @@ multiple worker threads.
 ### `new buffer.Blob([sources[, options]])`
 <!-- YAML
 added: v15.7.0
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/39708
+    description: Added the standard `endings` option to replace line-endings,
+                 and removed the non-standard `encoding` option.
 -->
 
 * `sources` {string[]|ArrayBuffer[]|TypedArray[]|DataView[]|Blob[]} An array
@@ -477,9 +482,9 @@ Creates a new `Blob` object containing a concatenation of the given sources.
 {ArrayBuffer}, {TypedArray}, {DataView}, and {Buffer} sources are copied into
 the 'Blob' and can therefore be safely modified after the 'Blob' is created.
 
-String sources are encoded as UTF-8 byte sequences and copied into the blob.
+String sources are encoded as UTF-8 byte sequences and copied into the Blob.
 Unmatched surrogate pairs within each string part will be replaced by Unicode
-0xFFFD replacement characters.
+U+FFFD replacement characters.
 
 ### `blob.arrayBuffer()`
 <!-- YAML

lib/internal/blob.js

@@ -9,6 +9,7 @@ const {
   PromiseReject,
   SafePromisePrototypeFinally,
   ReflectConstruct,
+  RegExpPrototypeSymbolReplace,
   RegExpPrototypeTest,
   StringPrototypeToLowerCase,
   StringPrototypeSplit,
@@ -111,7 +112,7 @@ function getSource(source, endings) {
   } else if (!isArrayBufferView(source)) {
     source = `${source}`;
     if (endings === 'native')
-      source = source.replaceAll(/(\n|\r\n)/g, lazyEOL());
+      source = RegExpPrototypeSymbolReplace(/\n|\r\n/g, source, lazyEOL());
     source = enc.encode(source);
   }
 
@@ -131,7 +132,7 @@ class Blob {
    * @param {{
    *   endings? : string,
    *   type? : string,
-   * }} options
+   * }} [options]
    * @returns
    */
   constructor(sources = [], options = {}) {
@@ -148,7 +149,7 @@ class Blob {
     } = options;
 
     endings = `${endings}`;
-    if (endings !== 'transparent' || endings !== 'native')
+    if (endings !== 'transparent' && endings !== 'native')
       throw new ERR_INVALID_ARG_VALUE('options.endings', endings);
 
     let length = 0;

test/parallel/test-blob.js

@@ -1,9 +1,11 @@
+// Flags: --no-warnings
 'use strict';
 
 const common = require('../common');
 const assert = require('assert');
 const { Blob } = require('buffer');
 const { inspect } = require('util');
+const { EOL } = require('os');
 
 {
   const b = new Blob();
@@ -210,7 +212,7 @@ assert.throws(() => new Blob({}), {
 
 {
   const b = new Blob(['hello\n'], { endings: 'native' });
-  assert.strictEqual(b.size, 7);
+  assert.strictEqual(b.size, EOL.length + 5);
 
   [1, {}, 'foo'].forEach((endings) => {
     assert.throws(() => new Blob([], { endings }), {