Commit ef00e5c
tools: fix cpplint --quiet option
Currently, the --quiet option for cpplint will generate the following
error:
$ tools/cpplint.py --quiet src/node.cc
Traceback (most recent call last):
File "tools/cpplint.py", line 6529, in <module>
main()
File "tools/cpplint.py", line 6497, in main
filenames = ParseArguments(sys.argv[1:])
File "tools/cpplint.py", line 6437, in ParseArguments
logger.addHandler(logging.FileHandler(val, mode='wb'))
File "/python2.7/logging/__init__.py", line 911, in __init__
StreamHandler.__init__(self, self._open())
File "/python2.7/logging/__init__.py", line 941, in _open
stream = open(self.baseFilename, self.mode)
IOError: [Errno 21] Is a directory: '/Users/danielbevenius/work/nodejs/node
This commit moves the FileHandler that currently exists in the quiet
option to the logfile clause. It looks like this issue came about when
merging in commit fee4d3a ("tools:
merge custom cpplint with cpplint v1.3.0").
PR-URL: #23075
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>1 parent 1cbc2ee commit ef00e5c
1 file changed
+2
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6429 | 6429 | | |
6430 | 6430 | | |
6431 | 6431 | | |
6432 | | - | |
6433 | | - | |
6434 | 6432 | | |
6435 | | - | |
| 6433 | + | |
6436 | 6434 | | |
| 6435 | + | |
6437 | 6436 | | |
6438 | 6437 | | |
6439 | 6438 | | |
| |||
0 commit comments