Skip to content

Commit ee17fcd

Browse files
aduh95ruyadorno
authored andcommitted
lib: prefer symbol to number in webidl type function
PR-URL: #55737 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com>
1 parent 18f0f07 commit ee17fcd

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

lib/internal/webidl.js

+9-8
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ const {
1515
ObjectAssign,
1616
SafeSet,
1717
String,
18+
Symbol,
1819
SymbolIterator,
1920
TypeError,
2021
} = primordials;
@@ -28,14 +29,14 @@ const { kEmptyObject } = require('internal/util');
2829

2930
const converters = { __proto__: null };
3031

31-
const UNDEFINED = 1;
32-
const BOOLEAN = 2;
33-
const STRING = 3;
34-
const SYMBOL = 4;
35-
const NUMBER = 5;
36-
const BIGINT = 6;
37-
const NULL = 7;
38-
const OBJECT = 8;
32+
const UNDEFINED = Symbol('undefined');
33+
const BOOLEAN = Symbol('boolean');
34+
const STRING = Symbol('string');
35+
const SYMBOL = Symbol('symbol');
36+
const NUMBER = Symbol('number');
37+
const BIGINT = Symbol('bigint');
38+
const NULL = Symbol('null');
39+
const OBJECT = Symbol('object');
3940

4041
/**
4142
* @see https://webidl.spec.whatwg.org/#es-any

0 commit comments

Comments
 (0)