Skip to content

Commit

Permalink
test: skip tests related to CI failures on AIX
Browse files Browse the repository at this point in the history
These tests seem to trigger failures in the entire CI job (not just the
test) on AIX. Skip them to see if that helps alleviate spurious failures
in node-test-commit-aix (and the upstream PR and commit test jobs).

See:
- nodejs/build#1820 (comment)
- nodejs/build#1847 (comment)

PR-URL: #28469
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
sam-github authored and targos committed Jul 2, 2019
1 parent 04740cc commit ec06ff4
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ const skipMessage = 'intensive toString tests due to memory confinements';
if (!common.enoughTestMem)
common.skip(skipMessage);

// See https://github.com/nodejs/build/issues/1820#issuecomment-505998851
// See https://github.com/nodejs/node/pull/28469
if (process.platform === 'aix')
common.skip('flaky on AIX');

const binding = require(`./build/${common.buildType}/binding`);

// v8 fails silently if string length > v8::String::kMaxLength
Expand Down
3 changes: 3 additions & 0 deletions test/message/message.status
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,6 @@ prefix message

[$system==freebsd]

[$system==aix]
# https://github.com/nodejs/node/pull/28469
vm_dont_display_syntax_error: SKIP
4 changes: 4 additions & 0 deletions test/pseudo-tty/pseudo-tty.status
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
prefix pseudo-tty

[$system==aix]
# https://github.com/nodejs/build/issues/1820#issuecomment-505998851
# https://github.com/nodejs/node/pull/28469
console-dumb-tty: SKIP
test-fatal-error: SKIP

[$system==solaris]
# https://github.com/nodejs/node/pull/16225 - `ioctl(fd, TIOCGWINSZ)` seems
Expand Down
3 changes: 3 additions & 0 deletions test/sequential/sequential.status
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,8 @@ test-http2-large-file: PASS, FLAKY
[$system==freebsd]

[$system==aix]
# https://github.com/nodejs/node/pull/28469
test-async-wrap-getasyncid: SKIP
test-buffer-creation-regression: SKIP

[$arch==arm]

0 comments on commit ec06ff4

Please sign in to comment.