Skip to content

Commit ebc370c

Browse files
devsnekdanielleadams
authored andcommitted
deps: V8: cherry-pick cc9a8a37445e
Original commit message: fix overflow check in error formatting Bug: v8:12494 Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Gus Caplan <snek@chromium.org> Cr-Commit-Position: refs/heads/main@{#78909} Refs: v8/v8@cc9a8a3 PR-URL: #41825 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent d422e58 commit ebc370c

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.19',
39+
'v8_embedder_string': '-node.20',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/execution/messages.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,8 +301,10 @@ MaybeHandle<Object> ErrorUtils::FormatStackTrace(Isolate* isolate,
301301
Handle<FixedArray> elems = Handle<FixedArray>::cast(raw_stack);
302302

303303
const bool in_recursion = isolate->formatting_stack_trace();
304+
const bool has_overflowed = i::StackLimitCheck{isolate}.HasOverflowed();
304305
Handle<Context> error_context;
305-
if (!in_recursion && error->GetCreationContext().ToHandle(&error_context)) {
306+
if (!in_recursion && !has_overflowed &&
307+
error->GetCreationContext().ToHandle(&error_context)) {
306308
DCHECK(error_context->IsNativeContext());
307309

308310
if (isolate->HasPrepareStackTraceCallback()) {

0 commit comments

Comments
 (0)