Skip to content

Commit eaaf3aa

Browse files
committed
doc: typography changes in CHANGELOG.md, CONTRIBUTING.md, GOVERNANCE.md, README.md, WORKING_GROUPS.md
1 parent 9f96705 commit eaaf3aa

File tree

5 files changed

+31
-31
lines changed

5 files changed

+31
-31
lines changed

CHANGELOG.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1838,7 +1838,7 @@ will be removed at a later point. (Roman Reiss) [#1363](https://github.com/nodej
18381838
This prevents a situation in which parsing the version number can use
18391839
exponentially more time and memory to parse, leading to a potential denial of
18401840
service. Thanks to Adam Baldwin at Lift Security for bringing this to our
1841-
attention. ([@isaacs](https://github.com/isaacs))
1841+
attention. ([@isaacs](https://github.com/isaacs))
18421842
* [`eab6184`](https://github.com/npm/npm/commit/eab618425c51e3aa4416da28dcd8ca4ba63aec41)
18431843
[#7766](https://github.com/npm/npm/issues/7766) One last tweak to ensure that
18441844
GitHub shortcuts work with private repositories.
@@ -2215,7 +2215,7 @@ will be removed at a later point. (Roman Reiss) [#1363](https://github.com/nodej
22152215
[#1999](https://github.com/npm/npm/issues/1999) Only run `stop` and `start`
22162216
scripts (plus their pre- and post- scripts) when there's no `restart` script
22172217
defined. This makes it easier to support graceful restarts of services
2218-
managed by npm. ([@watilde](https://github.com/watilde) /
2218+
managed by npm. ([@watilde](https://github.com/watilde) /
22192219
[@scien](https://github.com/scien))
22202220
* [`448efd0`](https://github.com/npm/npm/commit/448efd0eaa6f97af0889bf47efc543a1ea2f8d7e)
22212221
[#2853](https://github.com/npm/npm/issues/2853) Add support for `--dev` and
@@ -2977,7 +2977,7 @@ https://iojs.org/api/http.html
29772977
- Added `request.flush` method.
29782978
- Added `response.getHeader('header')` method that may be used before headers are flushed.
29792979
- Added `response.statusMessage` property.
2980-
- Added Client Keep-Alive behavior. Set `keepAlive:true` in request options to reuse connections indefinitely.
2980+
- Added Client Keep-Alive behavior. Set `keepAlive:true` in request options to reuse connections indefinitely.
29812981
- Added `rawHeaders` and `rawTrailers` members on incoming message.
29822982
- Removed default chunked encoding on `DELETE` and `OPTIONS`.
29832983

@@ -6342,7 +6342,7 @@ https://github.com/nodejs/node/commit/f711d5343b29d1e72e87107315708e40951a7826
63426342
pipeline
63436343

63446344
* Bugfix: http.Client may be prematurely released back to the
6345-
free pool. (Thomas Lee)
6345+
free pool. (Thomas Lee)
63466346

63476347
* Upgrade V8 to 2.2.8
63486348

CONTRIBUTING.md

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -45,21 +45,21 @@ and built upon.
4545
The rules for the master branch are less strict; consult the
4646
[stability index](./doc/api/documentation.markdown#stability-index) for details.
4747

48-
In a nutshell, modules are at varying levels of API stability. Bug fixes are
48+
In a nutshell, modules are at varying levels of API stability. Bug fixes are
4949
always welcome but API or behavioral changes to modules at stability level 3
5050
(Locked) are off-limits.
5151

5252
#### Dependencies
5353

5454
Node.js has several bundled dependencies in the *deps/* and the *tools/*
55-
directories that are not part of the project proper. Any changes to files
55+
directories that are not part of the project proper. Any changes to files
5656
in those directories or its subdirectories should be sent to their respective
57-
projects. Do not send your patch to us, we cannot accept it.
57+
projects. Do not send your patch to us, we cannot accept it.
5858

5959
In case of doubt, open an issue in the
6060
[issue tracker](https://github.com/nodejs/node/issues/) or contact one of the
6161
[project Collaborators](https://github.com/nodejs/node/#current-project-team-members).
62-
([IRC](http://webchat.freenode.net/?channels=io.js) is often the best medium.) Especially do so if you plan to work on something big. Nothing is more
62+
([IRC](http://webchat.freenode.net/?channels=io.js) is often the best medium.) Especially do so if you plan to work on something big. Nothing is more
6363
frustrating than seeing your hard work go to waste because your vision
6464
does not align with the project team.
6565

@@ -81,8 +81,8 @@ $ git config --global user.name "J. Random User"
8181
$ git config --global user.email "j.random.user@example.com"
8282
```
8383

84-
Writing good commit logs is important. A commit log should describe what
85-
changed and why. Follow these guidelines when writing one:
84+
Writing good commit logs is important. A commit log should describe what
85+
changed and why. Follow these guidelines when writing one:
8686

8787
1. The first line should be 50 characters or less and contain a short
8888
description of the change prefixed with the name of the changed
@@ -124,15 +124,15 @@ $ git rebase upstream/master
124124

125125
### Step 5: Test
126126

127-
Bug fixes and features **should come with tests**. Add your tests in the
128-
test/parallel/ directory. Look at other tests to see how they should be
127+
Bug fixes and features **should come with tests**. Add your tests in the
128+
test/parallel/ directory. Look at other tests to see how they should be
129129
structured (license boilerplate, common includes, etc.).
130130

131131
```text
132132
$ ./configure && make -j8 test
133133
```
134134

135-
Make sure the linter is happy and that all tests pass. Please, do not submit
135+
Make sure the linter is happy and that all tests pass. Please, do not submit
136136
patches that fail either check.
137137

138138
If you are updating tests and just want to run a single test to check it, you
@@ -160,9 +160,9 @@ $ git push origin my-feature-branch
160160
Go to https://github.com/yourusername/node and select your feature branch.
161161
Click the 'Pull Request' button and fill out the form.
162162

163-
Pull requests are usually reviewed within a few days. If there are comments
163+
Pull requests are usually reviewed within a few days. If there are comments
164164
to address, apply your changes in a separate commit and push that to your
165-
feature branch. Post a comment in the pull request afterwards; GitHub does
165+
feature branch. Post a comment in the pull request afterwards; GitHub does
166166
not send out notifications when you add commits.
167167

168168

@@ -201,7 +201,7 @@ CoC](http://www.rust-lang.org/conduct.html).
201201
* Please keep unstructured critique to a minimum. If you have solid
202202
ideas you want to experiment with, make a fork and see how it works.
203203
* We will exclude you from interaction if you insult, demean or harass
204-
anyone. That is not welcome behavior. We interpret the term
204+
anyone. That is not welcome behavior. We interpret the term
205205
"harassment" as including the definition in the [Citizen Code of
206206
Conduct](http://citizencodeofconduct.org/); if you have any lack of
207207
clarity about what might be included in that concept, please read
@@ -211,11 +211,11 @@ CoC](http://www.rust-lang.org/conduct.html).
211211
you feel you have been or are being harassed or made uncomfortable
212212
by a community member, please contact one of the channel ops or any
213213
of the TC members immediately with a capture (log, photo, email) of
214-
the harassment if possible. Whether you're a regular contributor or
214+
the harassment if possible. Whether you're a regular contributor or
215215
a newcomer, we care about making this community a safe place for you
216216
and we've got your back.
217217
* Likewise any spamming, trolling, flaming, baiting or other
218218
attention-stealing behavior is not welcome.
219219
* Avoid the use of personal pronouns in code comments or
220220
documentation. There is no need to address persons when explaining
221-
code (e.g. "When the developer")
221+
code (e.g. "When the developer").

GOVERNANCE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ A guide for Collaborators is maintained in
6363

6464
## TC Membership
6565

66-
TC seats are not time-limited. There is no fixed size of the TC.
66+
TC seats are not time-limited. There is no fixed size of the TC.
6767
However, the expected target is between 6 and 12, to ensure adequate
6868
coverage of important areas of expertise, balanced with the ability to
6969
make decisions efficiently.
@@ -80,7 +80,7 @@ Changes to TC membership should be posted in the agenda, and may be
8080
suggested as any other agenda item (see "TC Meetings" below).
8181

8282
No more than 1/3 of the TC members may be affiliated with the same
83-
employer. If removal or resignation of a TC member, or a change of
83+
employer. If removal or resignation of a TC member, or a change of
8484
employment by a TC member, creates a situation where more than 1/3 of
8585
the TC membership shares an employer, then the situation must be
8686
immediately remedied by the resignation or removal of one or more TC

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ enabled by default.
165165
#### "small" (English only) support
166166

167167
This option will build with "small" (English only) support, but
168-
the full `Intl` (ECMA-402) APIs. With `--download=all` it will
168+
the full `Intl` (ECMA-402) APIs. With `--download=all` it will
169169
download the ICU library as needed.
170170

171171
Unix / Macintosh:
@@ -264,11 +264,11 @@ It is possible to build Node.js with
264264
[OpenSSL FIPS module](https://www.openssl.org/docs/fips/fipsnotes.html).
265265

266266
**Note** that building in this way does **not** allow you to
267-
claim that the runtime is FIPS 140-2 validated. Instead you
268-
can indicate that the runtime uses a validated module. See
267+
claim that the runtime is FIPS 140-2 validated. Instead you
268+
can indicate that the runtime uses a validated module. See
269269
the [security policy]
270270
(http://csrc.nist.gov/groups/STM/cmvp/documents/140-1/140sp/140sp1747.pdf)
271-
page 60 for more details. In addition, the validation for
271+
page 60 for more details. In addition, the validation for
272272
the underlying module is only valid if it is deployed in
273273
accordance with its [security policy]
274274
(http://csrc.nist.gov/groups/STM/cmvp/documents/140-1/140sp/140sp1747.pdf).

WORKING_GROUPS.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ For the current list of Collaborators, see the project
340340

341341
### WG Membership
342342

343-
WG seats are not time-limited. There is no fixed size of the WG.
343+
WG seats are not time-limited. There is no fixed size of the WG.
344344
However, the expected target is between 6 and 12, to ensure adequate
345345
coverage of important areas of expertise, balanced with the ability to
346346
make decisions efficiently.
@@ -358,14 +358,14 @@ suggested as any other agenda item (see "WG Meetings" below).
358358

359359
If an addition or removal is proposed during a meeting, and the full
360360
WG is not in attendance to participate, then the addition or removal
361-
is added to the agenda for the subsequent meeting. This is to ensure
361+
is added to the agenda for the subsequent meeting. This is to ensure
362362
that all members are given the opportunity to participate in all
363-
membership decisions. If a WG member is unable to attend a meeting
363+
membership decisions. If a WG member is unable to attend a meeting
364364
where a planned membership decision is being made, then their consent
365365
is assumed.
366366

367367
No more than 1/3 of the WG members may be affiliated with the same
368-
employer. If removal or resignation of a WG member, or a change of
368+
employer. If removal or resignation of a WG member, or a change of
369369
employment by a WG member, creates a situation where more than 1/3 of
370370
the WG membership shares an employer, then the situation must be
371371
immediately remedied by the resignation or removal of one or more WG
@@ -416,7 +416,7 @@ either a closing vote or a vote to table the issue to the next
416416
meeting. The call for a vote must be seconded by a majority of the WG
417417
or else the discussion will continue. Simple majority wins.
418418

419-
Note that changes to WG membership require unanimous consensus. See
419+
Note that changes to WG membership require unanimous consensus. See
420420
"WG Membership" above.
421421

422422
### Developer's Certificate of Origin 1.0
@@ -454,7 +454,7 @@ CoC](https://github.com/rust-lang/rust/wiki/Note-development-policy#conduct).
454454
* Please keep unstructured critique to a minimum. If you have solid
455455
ideas you want to experiment with, make a fork and see how it works.
456456
* We will exclude you from interaction if you insult, demean or harass
457-
anyone. That is not welcome behaviour. We interpret the term
457+
anyone. That is not welcome behaviour. We interpret the term
458458
"harassment" as including the definition in the [Citizen Code of
459459
Conduct](http://citizencodeofconduct.org/); if you have any lack of
460460
clarity about what might be included in that concept, please read
@@ -464,7 +464,7 @@ CoC](https://github.com/rust-lang/rust/wiki/Note-development-policy#conduct).
464464
you feel you have been or are being harassed or made uncomfortable
465465
by a community member, please contact one of the channel ops or any
466466
of the TC members immediately with a capture (log, photo, email) of
467-
the harassment if possible. Whether you're a regular contributor or
467+
the harassment if possible. Whether you're a regular contributor or
468468
a newcomer, we care about making this community a safe place for you
469469
and we've got your back.
470470
* Likewise any spamming, trolling, flaming, baiting or other

0 commit comments

Comments
 (0)