src: avoid copying string in fs_permission

PR-URL: #47746 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
nodejs · May 3, 2023 · e948bec · e948bec
1 parent 33d1bd3
commit e948bec
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/permission/fs_permission.cc b/src/permission/fs_permission.cc
@@ -89,7 +89,7 @@ void FSPermission::Apply(const std::string& allow, PermissionScope scope) {
   }
 }
 
-void FSPermission::GrantAccess(PermissionScope perm, std::string res) {
+void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
   const std::string path = WildcardIfDir(res);
   if (perm == PermissionScope::kFileSystemRead) {
     granted_in_fs_.Insert(path);

diff --git a/src/permission/fs_permission.h b/src/permission/fs_permission.h
@@ -130,7 +130,7 @@ class FSPermission final : public PermissionBase {
   };
 
  private:
-  void GrantAccess(PermissionScope scope, std::string param);
+  void GrantAccess(PermissionScope scope, const std::string& param);
   void RestrictAccess(PermissionScope scope,
                       const std::vector<std::string>& params);
   // fs granted on startup