Commit e854bfa
test: create home for test-npm-install
This test currently fails if run as root:
npm ERR! makeDirectory homeless?
npm WARN install-dir No description
npm WARN install-dir No repository field.
npm WARN install-dir No license field.
npm ERR! path /root/node/test/.tmp.0/npm-sandbox/home
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall stat
npm ERR! enoent ENOENT:
no such file or directory,
stat '/root/node/test/.tmp.0/npm-sandbox/home'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
assert.js:89
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: npm install got error code 254
at handleExit (/root/node/test/parallel/test-npm-install.js:60:10)
at /root/node/test/common/index.js:371:15
at ChildProcess.exithandler (child_process.js:304:5)
at ChildProcess.emit (events.js:203:13)
at maybeClose (internal/child_process.js:1028:16)
at Process.ChildProcess._handle.onexit
(internal/child_process.js:283:5) {
generatedMessage: false,
code: 'ERR_ASSERTION',
actual: 254,
expected: 0,
operator: 'strictEqual'
}
The home directory will be created as expected by npm in the npmSandbox
when run as non-root, but when run as root this directory has to exist.
This commit creates the home directory to allow the test to pass also
when run as the root user.
Refs:https://github.com/npm/cli/blob/
31718e72cb5a03cee7127fc36843e4b55c868d93/
lib/utils/correct-mkdir.js#L82-L105
PR-URL: #28510
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 13f1393 commit e854bfa
1 file changed
+3
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
16 | 18 | | |
17 | 19 | | |
18 | 20 | | |
| |||
40 | 42 | | |
41 | 43 | | |
42 | 44 | | |
43 | | - | |
| 45 | + | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
| |||
0 commit comments