fixup! crypto: reduce memory usage of SignFinal

tniessen · tniessen · commit e5bd9d0f90fd · 2018-10-12T23:52:03.000+02:00
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -3631,7 +3631,7 @@ void Sign::SignFinal(const FunctionCallbackInfo<Value>& args) {
     return sign->CheckThrow(err);
 
   Local<Object> rc =
-      Buffer::New(env, reinterpret_cast<char*>(sig.data), sig.size)
+      Buffer::New(env, reinterpret_cast<char*>(sig.release()), sig.size)
       .ToLocalChecked();
   args.GetReturnValue().Set(rc);
 }

Original file line number	Diff line number	Diff line change
`@@ -3631,7 +3631,7 @@ void Sign::SignFinal(const FunctionCallbackInfo<Value>& args) {`
`3631`	`3631`	`return sign->CheckThrow(err);`
`3632`	`3632`
`3633`	`3633`	`Local<Object> rc =`
`3634`		`- Buffer::New(env, reinterpret_cast<char*>(sig.data), sig.size)`
	`3634`	`+ Buffer::New(env, reinterpret_cast<char*>(sig.release()), sig.size)`
`3635`	`3635`	`.ToLocalChecked();`
`3636`	`3636`	`args.GetReturnValue().Set(rc);`
`3637`	`3637`	`}`