http: don't emit 'data' after 'error'

PR-URL: #28711 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs · Sep 23, 2019 · e573c39 · e573c39
1 parent 1665a93
commit e573c39
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/lib/_http_client.js b/lib/_http_client.js
@@ -406,9 +406,6 @@ function socketErrorListener(err) {
     req.emit('error', err);
   }
 
-  // Handle any pending data
-  socket.read();
-
   const parser = socket.parser;
   if (parser) {
     parser.finish();

diff --git a/test/parallel/test-http-client-read-in-error.js b/test/parallel/test-http-client-read-in-error.js
@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+const common = require('../common');
 const net = require('net');
 const http = require('http');
 
@@ -37,4 +37,5 @@ http.request({
   agent
 }).once('error', function() {
   console.log('ignore');
+  this.on('data', common.mustNotCall());
 });