Skip to content

Commit e3cd79e

Browse files
committed
src: update NODE_MODULE_VERSION to 74
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 7.5. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #27375 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent d661500 commit e3cd79e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

doc/abi_version_registry.json

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"NODE_MODULE_VERSION": [
3+
{ "modules": 74, "runtime": "node", "variant": "v8_7.5", "versions": "13.0.0-pre" },
34
{ "modules": 73, "runtime": "electron", "variant": "electron", "versions": "6" },
45
{ "modules": 72, "runtime": "node", "variant": "v8_7.4", "versions": "12.0.0-pre" },
56
{ "modules": 71, "runtime": "node", "variant": "v8_7.3", "versions": "12.0.0-pre" },

src/node_version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
* version matching should open a pull request to reserve a number in this
9090
* registry.
9191
*/
92-
#define NODE_MODULE_VERSION 72
92+
#define NODE_MODULE_VERSION 74
9393

9494
// the NAPI_VERSION provided by this version of the runtime
9595
#define NAPI_VERSION 4

0 commit comments

Comments
 (0)