Skip to content

Commit

Permalink
test: remove flaky designation for test-cli-node-options
Browse files Browse the repository at this point in the history
The test failure is not platform-specific and is the result of
manual/human error. Some improvements may be possible, but there is
nothing fundamentally unsound about the test insofar as when it fails in
CI, there is a problem on the host that needs to be addressed and not an
inherent issue with the test.

Refs: #25028 (comment)
Closes: #25028

PR-URL: #27305
Fixes: #25028
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
Trott committed Apr 21, 2019
1 parent e9fb92d commit e37eee2
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ test-http2-client-upload-reject: PASS,FLAKY
[$system==macos]

[$arch==arm || $arch==arm64]
# https://github.com/nodejs/node/issues/25028
test-cli-node-options: PASS,FLAKY
# https://github.com/nodejs/node/issues/26610
test-async-hooks-http-parser-destroy: PASS,FLAKY

Expand Down

0 comments on commit e37eee2

Please sign in to comment.