From dfe5f8f288329ed1e92e46cc2507c16db8ae249e Mon Sep 17 00:00:00 2001 From: Yang Guo Date: Fri, 1 Feb 2019 13:21:15 +0100 Subject: [PATCH] test: do not fail SLOW tests if they are not slow PR-URL: https://github.com/nodejs/node/pull/25868 Refs: https://github.com/nodejs/node/issues/25867 Reviewed-By: Richard Lau Reviewed-By: Daniel Bevenius Reviewed-By: Refael Ackermann Reviewed-By: Anna Henningsen Reviewed-By: Gus Caplan --- tools/test.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/test.py b/tools/test.py index 6f0e71a3d470a6..e6fc7be73f11b1 100755 --- a/tools/test.py +++ b/tools/test.py @@ -1238,6 +1238,9 @@ def ClassifyTests(self, cases, env): outcomes = reduce(set.union, outcomes_list, set()) unused_rules.difference_update(matches) case.outcomes = set(outcomes) or set([PASS]) + # slow tests may also just pass. + if SLOW in case.outcomes: + case.outcomes.add(PASS) result.append(case) return result, unused_rules