Skip to content

Commit dd41480

Browse files
committed
lib: make WeakRef safe in abort_controller
1 parent dc74f17 commit dd41480

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lib/internal/abort_controller.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ const {
1010
PromiseResolve,
1111
SafeFinalizationRegistry,
1212
SafeSet,
13+
SafeWeakRef,
1314
Symbol,
1415
SymbolToStringTag,
15-
WeakRef,
1616
} = primordials;
1717

1818
const {
@@ -216,7 +216,7 @@ class AbortSignal extends EventTarget {
216216
signal[kTimeout] = true;
217217
clearTimeoutRegistry.register(
218218
signal,
219-
setWeakAbortSignalTimeout(new WeakRef(signal), delay));
219+
setWeakAbortSignalTimeout(new SafeWeakRef(signal), delay));
220220
return signal;
221221
}
222222

@@ -230,7 +230,7 @@ class AbortSignal extends EventTarget {
230230
if (!signals.length) {
231231
return resultSignal;
232232
}
233-
const resultSignalWeakRef = new WeakRef(resultSignal);
233+
const resultSignalWeakRef = new SafeWeakRef(resultSignal);
234234
resultSignal[kSourceSignals] = new SafeSet();
235235
for (let i = 0; i < signals.length; i++) {
236236
const signal = signals[i];
@@ -240,7 +240,7 @@ class AbortSignal extends EventTarget {
240240
}
241241
signal[kDependantSignals] ??= new SafeSet();
242242
if (!signal[kComposite]) {
243-
resultSignal[kSourceSignals].add(new WeakRef(signal));
243+
resultSignal[kSourceSignals].add(new SafeWeakRef(signal));
244244
signal[kDependantSignals].add(resultSignalWeakRef);
245245
} else if (!signal[kSourceSignals]) {
246246
continue;

0 commit comments

Comments
 (0)