Skip to content

Commit

Permalink
tools: add openssl-cli to macos-firewall.sh
Browse files Browse the repository at this point in the history
Currently, there is a new popup asking to accept incoming connections
for openssl-cli when running tests on macos. I believe the reason
for this not being noticed before is that test-tls-securepair-client.js
was moved recently from the pummel directory to sequential.

This commit adds openssl-cli to the firewall script.

PR-URL: #25385
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
danbev authored and addaleax committed Jan 14, 2019
1 parent b545b4c commit dcbf1d9
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions tools/macos-firewall.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ NODE_DEBUG="$OUTDIR/Debug/node"
NODE_LINK="$ROOTDIR/node"
CCTEST_RELEASE="$OUTDIR/Release/cctest"
CCTEST_DEBUG="$OUTDIR/Debug/cctest"
OPENSSL_CLI_RELEASE="$OUTDIR/Release/openssl-cli"
OPENSSL_CLI_DEBUG="$OUTDIR/Debug/openssl-cli"

if [ -f $SFW ];
then
Expand All @@ -31,18 +33,24 @@ then
$SFW --remove "$NODE_LINK"
$SFW --remove "$CCTEST_DEBUG"
$SFW --remove "$CCTEST_RELEASE"
$SFW --remove "$OPENSSL_CLI_DEBUG"
$SFW --remove "$OPENSSL_CLI_RELEASE"

$SFW --add "$NODE_DEBUG"
$SFW --add "$NODE_RELEASE"
$SFW --add "$NODE_LINK"
$SFW --add "$CCTEST_DEBUG"
$SFW --add "$CCTEST_RELEASE"
$SFW --add "$OPENSSL_CLI_DEBUG"
$SFW --add "$OPENSSL_CLI_RELEASE"

$SFW --unblock "$NODE_DEBUG"
$SFW --unblock "$NODE_RELEASE"
$SFW --unblock "$NODE_LINK"
$SFW --unblock "$CCTEST_DEBUG"
$SFW --unblock "$CCTEST_RELEASE"
$SFW --unblock "$OPENSSL_CLI_DEBUG"
$SFW --unblock "$OPENSSL_CLI_RELEASE"
else
echo "SocketFirewall not found in location: $SFW"
fi

0 comments on commit dcbf1d9

Please sign in to comment.