Skip to content

Commit d857e9a

Browse files
Myles BorinsFishrock123
Myles Borins
authored andcommitted
tools: explicit path for V8 test tap output
Currently we do not specific an absolute path for the tap output of the V8 test suite. This is proving to be unreliable across release lines. By prepending `$(PWD)` to each path we can guarantee it will always be in the root folder. PR-URL: #7460 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent 658ab3d commit d857e9a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ ifdef QUICKCHECK
1919
endif
2020

2121
ifdef ENABLE_V8_TAP
22-
TAP_V8 := --junitout v8-tap.xml
23-
TAP_V8_INTL := --junitout v8-intl-tap.xml
24-
TAP_V8_BENCHMARKS := --junitout v8-benchmarks-tap.xml
22+
TAP_V8 := --junitout $(PWD)/v8-tap.xml
23+
TAP_V8_INTL := --junitout $(PWD)/v8-intl-tap.xml
24+
TAP_V8_BENCHMARKS := --junitout $(PWD)/v8-benchmarks-tap.xml
2525
endif
2626

2727
V8_TEST_OPTIONS = $(V8_EXTRA_TEST_OPTIONS)

0 commit comments

Comments
 (0)