test_runner: prevent rerunning deleted files

pmarchini · pmarchini · commit d74731a021a1 · 2024-08-16T06:52:32.000+02:00
diff --git a/lib/internal/test_runner/runner.js b/lib/internal/test_runner/runner.js
@@ -427,6 +427,7 @@ function watchFiles(testFiles, opts) {
       const updatedTestFiles = createTestFileList(opts.globPatterns);
 
       const newFileName = ArrayPrototypeFind(updatedTestFiles, (x) => !ArrayPrototypeIncludes(testFiles, x));
+      const previousFileName = ArrayPrototypeFind(testFiles, (x) => !ArrayPrototypeIncludes(updatedTestFiles, x));
 
       // When file renamed (created / deleted) we need to update the watcher
       if (newFileName) {
@@ -438,6 +439,8 @@ function watchFiles(testFiles, opts) {
         return; // Avoid rerunning files when file deleted
       }
 
+
+      testFiles = updatedTestFiles;
     }
 
     watcher.unfilterFilesOwnedBy(owners);

Original file line number	Diff line number	Diff line change
`@@ -427,6 +427,7 @@ function watchFiles(testFiles, opts) {`
`427`	`427`	`const updatedTestFiles = createTestFileList(opts.globPatterns);`
`428`	`428`
`429`	`429`	`const newFileName = ArrayPrototypeFind(updatedTestFiles, (x) => !ArrayPrototypeIncludes(testFiles, x));`
	`430`	`+ const previousFileName = ArrayPrototypeFind(testFiles, (x) => !ArrayPrototypeIncludes(updatedTestFiles, x));`
`430`	`431`
`431`	`432`	`// When file renamed (created / deleted) we need to update the watcher`
`432`	`433`	`if (newFileName) {`
`@@ -438,6 +439,8 @@ function watchFiles(testFiles, opts) {`
`438`	`439`	`return; // Avoid rerunning files when file deleted`
`439`	`440`	`}`
`440`	`441`
	`442`	`+`
	`443`	`+ testFiles = updatedTestFiles;`
`441`	`444`	`}`
`442`	`445`
`443`	`446`	`watcher.unfilterFilesOwnedBy(owners);`