Skip to content

Commit d73e710

Browse files
deps: patch V8 to support compilation with MSVC
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
1 parent c30c398 commit d73e710

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.4',
39+
'v8_embedder_string': '-node.5',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/execution/frames.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1269,11 +1269,11 @@ class WasmFrame : public TypedFrame {
12691269
void Summarize(std::vector<FrameSummary>* frames) const override;
12701270

12711271
static WasmFrame* cast(StackFrame* frame) {
1272-
DCHECK(frame->is_wasm()
12731272
#ifdef V8_ENABLE_DRUMBRAKE
1274-
&& !frame->is_wasm_interpreter_entry()
1273+
DCHECK(frame->is_wasm() && !frame->is_wasm_interpreter_entry());
1274+
#else
1275+
DCHECK(frame->is_wasm());
12751276
#endif // V8_ENABLE_DRUMBRAKE
1276-
);
12771277
return static_cast<WasmFrame*>(frame);
12781278
}
12791279

deps/v8/src/objects/tagged-field.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,10 @@ static_assert(sizeof(UnalignedDoubleMember) == sizeof(double));
101101
#define FLEXIBLE_ARRAY_MEMBER(Type, name) \
102102
using FlexibleDataReturnType = Type[0]; \
103103
FlexibleDataReturnType& name() { \
104-
static_assert(alignof(Type) <= alignof(decltype(*this))); \
105104
using ReturnType = Type[0]; \
106105
return reinterpret_cast<ReturnType&>(*(this + 1)); \
107106
} \
108107
const FlexibleDataReturnType& name() const { \
109-
static_assert(alignof(Type) <= alignof(decltype(*this))); \
110108
using ReturnType = Type[0]; \
111109
return reinterpret_cast<const ReturnType&>(*(this + 1)); \
112110
} \

0 commit comments

Comments
 (0)