From d71b467bbe8ffa5cacb54ff70b7329256b7f9c0a Mon Sep 17 00:00:00 2001 From: Myles Borins Date: Fri, 18 Sep 2020 12:55:59 -0400 Subject: [PATCH] doc: put release script specifics in details MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Listing all the steps can be confusing an make it seem like the releaser is meant to run each of these steps manually. In fact I personally did that my first release. Let's put those steps in a details block to make it more obvious that it is informational and not steps to follow PR-URL: https://github.com/nodejs/node/pull/35260 Reviewed-By: Richard Lau Reviewed-By: Ruy Adorno Reviewed-By: Daijiro Wachi Reviewed-By: Anna Henningsen Reviewed-By: Michaël Zasso --- doc/guides/releases.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/releases.md b/doc/guides/releases.md index c828a4b2826821..e66204e8d007a0 100644 --- a/doc/guides/releases.md +++ b/doc/guides/releases.md @@ -598,6 +598,8 @@ $ ./tools/release.sh -i ~/.ssh/node_id_rsa `tools/release.sh` will perform the following actions when run: +
+ **a.** Select a GPG key from your private keys. It will use a command similar to: `gpg --list-secret-keys` to list your keys. If you don't have any keys, it will bail. If you have only one key, it will use that. If you have more than @@ -631,6 +633,7 @@ SHASUMS256.txt.sig. **g.** Upload the `SHASUMS256.txt` files back to the server into the release directory. +
If you didn't wait for ARM builds in the previous step before promoting the release, you should re-run `tools/release.sh` after the ARM builds have