Skip to content

Commit d586070

Browse files
codebyteretargos
authored andcommitted
src: allow inspector without v8 platform
Embedders sometimes want to take control of V8 platform initialization themselves, so we wouldn't want to experience an error if NODE_USE_V8_PLATFORM was false necessarily. Instead, we can also gate it with HAVE_INSPECTOR to allow embedders to define that themselves and use Inspector without NODE_USE_V8_PLATFORM. PR-URL: #30049 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
1 parent c4c8e01 commit d586070

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/node_options.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ std::shared_ptr<PerProcessOptions> cli_options{new PerProcessOptions()};
2727
} // namespace per_process
2828

2929
void DebugOptions::CheckOptions(std::vector<std::string>* errors) {
30-
#if !NODE_USE_V8_PLATFORM
30+
#if !NODE_USE_V8_PLATFORM && !HAVE_INSPECTOR
3131
if (inspector_enabled) {
3232
errors->push_back("Inspector is not available when Node is compiled "
33-
"--without-v8-platform");
33+
"--without-v8-platform and --without-inspector.");
3434
}
3535
#endif
3636

0 commit comments

Comments
 (0)