test: remove common.PORT from multiple tests

PR-URL: #12451 Ref: #12376 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Jun 20, 2017 · d5491fc · d5491fc
1 parent 6df6af1
commit d5491fc
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 14 deletions.
diff --git a/test/parallel/test-cluster-master-error.js b/test/parallel/test-cluster-master-error.js
@@ -10,7 +10,7 @@ if (cluster.isWorker) {
   const http = require('http');
   http.Server(() => {
 
-  }).listen(common.PORT, '127.0.0.1');
+  }).listen(0, '127.0.0.1');
 
 } else if (process.argv[2] === 'cluster') {
 

diff --git a/test/parallel/test-cluster-master-kill.js b/test/parallel/test-cluster-master-kill.js
@@ -7,7 +7,7 @@ if (cluster.isWorker) {
 
   // keep the worker alive
   const http = require('http');
-  http.Server().listen(common.PORT, '127.0.0.1');
+  http.Server().listen(0, '127.0.0.1');
 
 } else if (process.argv[2] === 'cluster') {
 

diff --git a/test/parallel/test-cluster-net-send.js b/test/parallel/test-cluster-net-send.js
@@ -46,8 +46,8 @@ if (process.argv[2] !== 'child') {
     socketConnected();
   });
 
-  server.listen(common.PORT, function() {
-    socket = net.connect(common.PORT, '127.0.0.1', socketConnected);
+  server.listen(0, function() {
+    socket = net.connect(server.address().port, '127.0.0.1', socketConnected);
   });
 
   process.on('disconnect', function() {

diff --git a/test/parallel/test-cluster-rr-domain-listen.js b/test/parallel/test-cluster-rr-domain-listen.js
@@ -1,5 +1,5 @@
 'use strict';
-const common = require('../common');
+require('../common');
 const cluster = require('cluster');
 const domain = require('domain');
 
@@ -11,7 +11,7 @@ if (cluster.isWorker) {
   d.run(function() { });
 
   const http = require('http');
-  http.Server(function() { }).listen(common.PORT, '127.0.0.1');
+  http.Server(function() { }).listen(0, '127.0.0.1');
 
 } else if (cluster.isMaster) {
   let worker;

diff --git a/test/parallel/test-cluster-rr-ref.js b/test/parallel/test-cluster-rr-ref.js
@@ -10,7 +10,7 @@ if (cluster.isMaster) {
   });
 } else {
   const server = net.createServer(common.mustNotCall());
-  server.listen(common.PORT, function() {
+  server.listen(0, function() {
     server.unref();
     server.ref();
     server.close(function() {

diff --git a/test/parallel/test-cluster-shared-leak.js b/test/parallel/test-cluster-shared-leak.js
@@ -13,10 +13,10 @@ if (cluster.isMaster) {
   let conn, worker2;
 
   const worker1 = cluster.fork();
-  worker1.on('message', common.mustCall(function() {
+  worker1.on('listening', common.mustCall(function(address) {
     worker2 = cluster.fork();
     worker2.on('online', function() {
-      conn = net.connect(common.PORT, common.mustCall(function() {
+      conn = net.connect(address.port, common.mustCall(function() {
         worker1.disconnect();
         worker2.disconnect();
       }));
@@ -48,6 +48,4 @@ const server = net.createServer(function(c) {
   c.end('bye');
 });
 
-server.listen(common.PORT, function() {
-  process.send('listening');
-});
+server.listen(0);
diff --git a/test/parallel/test-cluster-worker-no-exit.js b/test/parallel/test-cluster-worker-no-exit.js
@@ -1,5 +1,5 @@
 'use strict';
-const common = require('../common');
+require('../common');
 const assert = require('assert');
 const cluster = require('cluster');
 const net = require('net');
@@ -34,7 +34,7 @@ if (cluster.isMaster) {
       success = true;
     });
 
-  }).listen(common.PORT, function() {
+  }).listen(0, function() {
     const port = this.address().port;
 
     worker = cluster.fork()