Skip to content

Commit

Permalink
test: make use of globals explicit
Browse files Browse the repository at this point in the history
Use `global` to be explicit that a global variable is intended.

PR-URL: #6014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott committed Apr 5, 2016
1 parent ae2be27 commit d416a59
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions test/parallel/test-vm-static-this.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,25 +14,25 @@ assert.throws(function() {
vm.runInThisContext('throw new Error(\'test\');');
}, /test/);

hello = 5;
global.hello = 5;
vm.runInThisContext('hello = 2');
assert.equal(2, hello);
assert.equal(2, global.hello);


console.error('pass values');
code = 'foo = 1;' +
var code = 'foo = 1;' +
'bar = 2;' +
'if (typeof baz !== \'undefined\') throw new Error(\'test fail\');';
foo = 2;
obj = { foo: 0, baz: 3 };
global.foo = 2;
global.obj = { foo: 0, baz: 3 };
/* eslint-disable no-unused-vars */
var baz = vm.runInThisContext(code);
/* eslint-enable no-unused-vars */
assert.equal(0, obj.foo);
assert.equal(2, bar);
assert.equal(1, foo);
assert.equal(0, global.obj.foo);
assert.equal(2, global.bar);
assert.equal(1, global.foo);

console.error('call a function');
f = function() { foo = 100; };
global.f = function() { global.foo = 100; };
vm.runInThisContext('f()');
assert.equal(100, foo);
assert.equal(100, global.foo);

0 comments on commit d416a59

Please sign in to comment.