TLS/SSL: Removes unnecessary code branching

Removes branch that would make TLSSocket emit '_tlsError' event if error occured on handshake and controll was not released, as it was never happening. Addedd test for tls.Server to ensure it still emits 'tlsClientError' as expected.

Makes tests conform to defined linting rules.

Author: lekoder

lib/_tls_wrap.js

@@ -426,13 +426,9 @@ TLSSocket.prototype._init = function(socket, wrap) {
 
     // Destroy socket if error happened before handshake's finish
     if (!self._secureEstablished) {
-      if (!self._controlReleased) {
-        // When handshake fails control is not yet released,
-        // so self._tlsError will return null instead of actual error
-        self.destroy(err);
-      } else {
-        self.destroy(self._tlsError(err));
-      }
+      // When handshake fails control is not yet released,
+      // so self._tlsError will return null instead of actual error
+      self.destroy(err);
     } else if (options.isServer &&
                rejectUnauthorized &&
                /peer did not return a certificate/.test(err.message)) {

test/parallel/test-tls-server-failed-handshake-emits-clienterror.js

@@ -0,0 +1,37 @@
+'use strict';
+const common = require('../common');
+
+if (!common.hasCrypto) {
+  common.skip('missing crypto');
+  return;
+}
+const tls = require('tls');
+const net = require('net');
+const assert = require('assert');
+
+const bonkers = Buffer.alloc(1024, 42);
+
+let tlsClientErrorEmited = false;
+
+const server = tls.createServer({})
+  .listen(0, function() {
+    const c = net.connect({ port: this.address().port }, function() {
+      c.write(bonkers);
+    });
+
+  }).on('tlsClientError', function(e) {
+    tlsClientErrorEmited = true;
+    assert.ok(e instanceof Error,
+              'Instance of Error should be passed to error handler');
+    assert.ok(e.message.match(
+      /SSL routines:SSL23_GET_CLIENT_HELLO:unknown protocol/),
+      'Expecting SSL unknown protocol');
+  });
+
+setTimeout(function() {
+  server.close();
+
+  assert.ok(tlsClientErrorEmited,
+            'tlsClientError should be emited');
+
+}, common.platformTimeout(200));

test/parallel/test-tls-failed-handshake-emits-error.js renamed to test/parallel/test-tls-socket-failed-handshake-emits-error.js

@@ -20,7 +20,7 @@ const server = net.createServer(function(c) {
 
     s.on('error', common.mustCall(function(e) {
       assert.ok(e instanceof Error,
-        'Instance of Error should be passed to error handler');
+                'Instance of Error should be passed to error handler');
       assert.ok(e.message.match(
         /SSL routines:SSL23_GET_CLIENT_HELLO:unknown protocol/),
         'Expecting SSL unknown protocol');