diff --git a/.github/workflows/create-release-proposal.yml b/.github/workflows/create-release-proposal.yml index 1aace5e1a21b22..afb82ed89a3a6d 100644 --- a/.github/workflows/create-release-proposal.yml +++ b/.github/workflows/create-release-proposal.yml @@ -41,7 +41,6 @@ jobs: # Needs the whole git history for ncu to work # See https://github.com/nodejs/node-core-utils/pull/486 fetch-depth: 0 - token: ${{ secrets.GH_USER_TOKEN }} # Install dependencies - name: Install Node.js @@ -59,7 +58,7 @@ jobs: - name: Configure @node-core/utils run: | - ncu-config set branch ${{ env.RELEASE_BRANCH }} + ncu-config set branch "${RELEASE_BRANCH}" ncu-config set upstream origin ncu-config set username "$USERNAME" ncu-config set token "$GH_TOKEN" @@ -72,4 +71,5 @@ jobs: JENKINS_TOKEN: ${{ secrets.JENKINS_TOKEN }} - name: Start git node release prepare - run: ./tools/actions/create-release.sh ${{ inputs.RELEASE_DATE }} + run: | + ./tools/actions/create-release.sh "${RELEASE_DATE}" diff --git a/tools/actions/create-release.sh b/tools/actions/create-release.sh index a39cf24dc4e81d..21907b1217bb11 100755 --- a/tools/actions/create-release.sh +++ b/tools/actions/create-release.sh @@ -8,7 +8,6 @@ git node release --prepare --skipBranchDiff # We use it to not specify the branch name as it changes based on # the commit list (semver-minor/semver-patch) git config push.default current -git push upstream echo "/## $RELEASE_DATE/,/^ temp.awk awk -f temp.awk doc/changelogs/CHANGELOG_V23.md > pr-body.md gh pr create --body-file pr-body.md