Skip to content

Commit d25af5a

Browse files
committed
fixup! fixup! fixup! test,debugger: migrate node-inspect tests to core
1 parent ec0dcd7 commit d25af5a

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

test/inspector-cli/test-inspector-cli-preserve-breaks.js

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -53,18 +53,19 @@ const path = require('path');
5353
})
5454
.then(() => cli.command('breakpoints'))
5555
.then(() => {
56-
if (process.platform === 'aix') {
57-
// TODO: There is a known issue on AIX where the breakpoints aren't
58-
// properly resolved yet when we reach this point.
59-
// Eventually that should be figured out but for now we don't want
60-
// to fail builds because of it.
61-
assert.match(cli.output, /#0 [^\n]+three-lines\.js\$?:2/);
62-
assert.match(cli.output, /#1 [^\n]+three-lines\.js\$?:3/);
63-
} else {
64-
const msg = `SCRIPT: ${script}, OUTPUT: ${cli.output}`;
65-
assert.ok(cli.output.includes(`#0 ${script}:2`), msg);
66-
assert.ok(cli.output.includes(`#1 ${script}:3`), msg);
67-
}
56+
// TODO: There is a known issue on AIX and some other operating systems
57+
// where the breakpoints aren't properly resolved yet when we reach this
58+
// point. Eventually that should be figured out but for now we don't
59+
// want to fail builds because of it.
60+
// What it should be:
61+
//
62+
// const msg = `SCRIPT: ${script}, OUTPUT: ${cli.output}`;
63+
// assert.ok(cli.output.includes(`#0 ${script}:2`), msg);
64+
// assert.ok(cli.output.includes(`#1 ${script}:3`), msg);
65+
//
66+
// What we're doing for now instead:
67+
assert.match(cli.output, /#0 [^\n]+three-lines\.js\$?:2/);
68+
assert.match(cli.output, /#1 [^\n]+three-lines\.js\$?:3/);
6869
})
6970
.then(() => cli.quit())
7071
.then(null, onFatal);

0 commit comments

Comments
 (0)