Skip to content

Commit

Permalink
url: do not use HandleScope in ToObject
Browse files Browse the repository at this point in the history
It is not needed / invalidates the returned value unlike EscapableHandleScope

PR-URL: #14096
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
bmeck authored and addaleax committed Jul 18, 2017
1 parent 784102f commit d23c49f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/node_url.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2085,7 +2085,6 @@ static void DomainToUnicode(const FunctionCallbackInfo<Value>& args) {
const Local<Value> URL::ToObject(Environment* env) const {
Isolate* isolate = env->isolate();
Local<Context> context = env->context();
HandleScope handle_scope(isolate);
Context::Scope context_scope(context);

const Local<Value> undef = Undefined(isolate);
Expand Down

0 comments on commit d23c49f

Please sign in to comment.