Skip to content

Commit d09008a

Browse files
targosmarco-ippolito
authored andcommitted
deps: V8: cherry-pick 1a3ecc2483b2
Original commit message: Fix build issue, remove unneeded include uchar.h. Follow the conversation on: https://groups.google.com/g/v8-dev/c/nsbshwlmP3c. The `uchar.h` include is not necessary. It was added to get the definition of char16_t but that's an intrinsic type in C++. Change-Id: I0aaa11dba0be3ccad15b9e421f8bae71450d443b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4823404 Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/main@{#89787} Refs: v8/v8@1a3ecc2 PR-URL: #49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #58342 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent fd56652 commit d09008a

File tree

4 files changed

+2
-3
lines changed

4 files changed

+2
-3
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.28',
39+
'v8_embedder_string': '-node.29',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ Matt Hanselman <mjhanselman@gmail.com>
188188
Matthew Sporleder <msporleder@gmail.com>
189189
Maxim Mazurok <maxim@mazurok.com>
190190
Maxim Mossienko <maxim.mossienko@gmail.com>
191+
Meir Shpilraien <meir@redis.com>
191192
Michael Lutz <michi@icosahedron.de>
192193
Michael Mclaughlin <m8ch88l@gmail.com>
193194
Michael Smith <mike@w3.org>

deps/v8/src/inspector/string-16.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
#define V8_INSPECTOR_STRING_16_H_
77

88
#include <stdint.h>
9-
#include <uchar.h>
109

1110
#include <cctype>
1211
#include <climits>

deps/v8/src/inspector/v8-string-conversions.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
#ifndef V8_INSPECTOR_V8_STRING_CONVERSIONS_H_
66
#define V8_INSPECTOR_V8_STRING_CONVERSIONS_H_
77

8-
#include <uchar.h>
98

109
#include <cstdint>
1110
#include <string>

0 commit comments

Comments
 (0)