src: avoid custom functions in async mode

Author: geeksilva97

src/node_sqlite.cc

@@ -1318,6 +1318,10 @@ void Database::CustomFunction(const FunctionCallbackInfo<Value>& args) {
   ASSIGN_OR_RETURN_UNWRAP(&db, args.This());
   Environment* env = Environment::GetCurrent(args);
   THROW_AND_RETURN_ON_BAD_STATE(env, !db->IsOpen(), "database is not open");
+  THROW_AND_RETURN_ON_BAD_STATE(
+      env,
+      db->is_async(),
+      "Custom functions are not supported in async mode");
 
   if (!args[0]->IsString()) {
     THROW_ERR_INVALID_ARG_TYPE(env->isolate(),
@@ -1491,6 +1495,10 @@ void Database::AggregateFunction(const FunctionCallbackInfo<Value>& args) {
   ASSIGN_OR_RETURN_UNWRAP(&db, args.This());
   Environment* env = Environment::GetCurrent(args);
   THROW_AND_RETURN_ON_BAD_STATE(env, !db->IsOpen(), "database is not open");
+  THROW_AND_RETURN_ON_BAD_STATE(
+      env,
+      db->is_async(),
+      "Aggregate functions are not supported in async mode");
   Utf8Value name(env->isolate(), args[0].As<String>());
   Local<Object> options = args[1].As<Object>();
   Local<Value> start_v;
@@ -2055,6 +2063,10 @@ void Database::SetAuthorizer(const FunctionCallbackInfo<Value>& args) {
   Database* db;
   ASSIGN_OR_RETURN_UNWRAP(&db, args.This());
   Environment* env = Environment::GetCurrent(args);
+  THROW_AND_RETURN_ON_BAD_STATE(
+      env,
+      db->is_async(),
+      "Authorizer callbacks are not supported in async mode");
   Isolate* isolate = env->isolate();
 
   if (args[0]->IsNull()) {

test/parallel/test-sqlite-database-async.mjs

@@ -524,3 +524,41 @@ suite('Database.prototype.location()', () => {
     t.assert.strictEqual(db.location('other'), otherPath);
   });
 });
+
+suite('Async mode restrictions', () => {
+  test('throws when defining a custom function', (t) => {
+    const db = new Database(':memory:');
+    t.after(() => { db.close(); });
+
+    t.assert.throws(() => {
+      db.function('test', () => 1);
+    }, {
+      code: 'ERR_INVALID_STATE',
+      message: /Custom functions are not supported in async mode/,
+    });
+  });
+
+  test('throws when defining an aggregate function', (t) => {
+    const db = new Database(':memory:');
+    t.after(() => { db.close(); });
+
+    t.assert.throws(() => {
+      db.aggregate('test', { start: 0, step: (acc) => acc });
+    }, {
+      code: 'ERR_INVALID_STATE',
+      message: /Aggregate functions are not supported in async mode/,
+    });
+  });
+
+  test('throws when setting an authorizer callback', (t) => {
+    const db = new Database(':memory:');
+    t.after(() => { db.close(); });
+
+    t.assert.throws(() => {
+      db.setAuthorizer(() => 0);
+    }, {
+      code: 'ERR_INVALID_STATE',
+      message: /Authorizer callbacks are not supported in async mode/,
+    });
+  });
+});