buffer: avoid creating unnecessary environment

anonrig · RafaelGSS · commit ca86c933908f · 2025-05-02T17:06:56.000-03:00
PR-URL: #58053 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
diff --git a/src/node_buffer.cc b/src/node_buffer.cc
@@ -721,11 +721,11 @@ void StringWrite(const FunctionCallbackInfo<Value>& args) {
 }
 
 void SlowByteLengthUtf8(const FunctionCallbackInfo<Value>& args) {
-  Environment* env = Environment::GetCurrent(args);
   CHECK(args[0]->IsString());
 
   // Fast case: avoid StringBytes on UTF8 string. Jump to v8.
-  args.GetReturnValue().Set(args[0].As<String>()->Utf8Length(env->isolate()));
+  args.GetReturnValue().Set(
+      args[0].As<String>()->Utf8Length(args.GetIsolate()));
 }
 
 uint32_t FastByteLengthUtf8(

Original file line number	Diff line number	Diff line change
`@@ -721,11 +721,11 @@ void StringWrite(const FunctionCallbackInfo<Value>& args) {`
`721`	`721`	`}`
`722`	`722`
`723`	`723`	`void SlowByteLengthUtf8(const FunctionCallbackInfo<Value>& args) {`
`724`		`- Environment* env = Environment::GetCurrent(args);`
`725`	`724`	`CHECK(args[0]->IsString());`
`726`	`725`
`727`	`726`	`// Fast case: avoid StringBytes on UTF8 string. Jump to v8.`
`728`		`- args.GetReturnValue().Set(args[0].As<String>()->Utf8Length(env->isolate()));`
	`727`	`+ args.GetReturnValue().Set(`
	`728`	`+ args[0].As<String>()->Utf8Length(args.GetIsolate()));`
`729`	`729`	`}`
`730`	`730`
`731`	`731`	`uint32_t FastByteLengthUtf8(`