Skip to content

Commit c9296b1

Browse files
committed
deps: V8: cherry-pick 2a0bc36dec12
Original commit message: [parser] Fix the MSVC build MSVC seems to instantiate the Parser::PreParserIdentifierToAstRawString method despite it being unused. This CL adds an (unreachable) definition for it. Bug: v8:12266 Change-Id: I355ca82a9d6b7bc8cd16768a8df93e40f8bfc638 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199856 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77313} Refs: v8/v8@2a0bc36 PR-URL: #40178 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 5b35837 commit c9296b1

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.9',
39+
'v8_embedder_string': '-node.10',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/parsing/parser.h

+7
Original file line numberDiff line numberDiff line change
@@ -709,6 +709,13 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) {
709709
return arg;
710710
}
711711

712+
const AstRawString* PreParserIdentifierToAstRawString(
713+
const PreParserIdentifier& arg) {
714+
// This method definition is only needed due to an MSVC oddity that
715+
// instantiates the method despite it being unused. See crbug.com/v8/12266 .
716+
UNREACHABLE();
717+
}
718+
712719
IterationStatement* AsIterationStatement(BreakableStatement* s) {
713720
return s->AsIterationStatement();
714721
}

0 commit comments

Comments
 (0)