Skip to content

Commit c892f35

Browse files
bnoordhuisdanielleadams
authored andcommitted
deps: V8: fix debug build
This is a (very) partial cherry-pick of upstream change v8/v8@f8fddd6b13 that fixes the following debug mode build error with clang: ../deps/v8/src/codegen/register.h:29:48: error: member reference base type 'RegListBase' is not a structure or union int num_different_regs = RegListBase{regs...}.Count(); Fixes: #44371 PR-URL: #44392 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
1 parent 576ccdf commit c892f35

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

deps/v8/src/codegen/register.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ template <typename... RegTypes,
2626
std::conjunction_v<std::is_same<Register, RegTypes>...> ||
2727
std::conjunction_v<std::is_same<DoubleRegister, RegTypes>...>>>
2828
inline constexpr bool AreAliased(RegTypes... regs) {
29-
int num_different_regs = RegListBase{regs...}.Count();
29+
using FirstRegType = std::tuple_element_t<0, std::tuple<RegTypes...>>;
30+
int num_different_regs = RegListBase<FirstRegType>{regs...}.Count();
3031
int num_given_regs = (... + (regs.is_valid() ? 1 : 0));
3132
return num_different_regs < num_given_regs;
3233
}

0 commit comments

Comments
 (0)