Skip to content

Commit c8625d1

Browse files
targosdanielleadams
authored andcommitted
build: re-enable V8 concurrent marking
It was unintentionally disabled during a V8 update. Fixes: #41012 PR-URL: #41013 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 4aae04b commit c8625d1

File tree

2 files changed

+19
-6
lines changed

2 files changed

+19
-6
lines changed

tools/v8_gypfiles/features.gypi

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,16 @@
147147
# Sets -dV8_TRACE_FEEDBACK_UPDATES.
148148
'v8_enable_trace_feedback_updates%': 0,
149149

150+
# Sets -dV8_ATOMIC_OBJECT_FIELD_WRITES and turns all field write operations
151+
# into relaxed atomic operations.
152+
'v8_enable_atomic_object_field_writes%': 1,
153+
154+
# Sets -dV8_ATOMIC_MARKING_STATE
155+
'v8_enable_atomic_marking_state%': 1,
156+
157+
# Has no effect in Node.js. Here for completeness with V8's config.
158+
'v8_enable_concurrent_marking%': 1,
159+
150160
# Enables various testing features.
151161
'v8_enable_test_features%': 0,
152162

@@ -346,6 +356,12 @@
346356
['v8_enable_third_party_heap==1', {
347357
'defines': ['V8_ENABLE_THIRD_PARTY_HEAP',],
348358
}],
359+
['v8_enable_atomic_object_field_writes==1', {
360+
'defines': ['V8_ATOMIC_OBJECT_FIELD_WRITES',],
361+
}],
362+
['v8_enable_atomic_marking_state==1', {
363+
'defines': ['V8_ATOMIC_MARKING_STATE',],
364+
}],
349365
['v8_enable_lazy_source_positions==1', {
350366
'defines': ['V8_ENABLE_LAZY_SOURCE_POSITIONS',],
351367
}],

tools/v8_gypfiles/v8.gyp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1775,12 +1775,9 @@
17751775
'is_ubsan_vptr=0',
17761776
'target_cpu=<(target_arch)',
17771777
'v8_current_cpu=<(v8_current_cpu)',
1778-
# Not available in gyp.
1779-
'v8_enable_atomic_marking_state=0',
1780-
# Not available in gyp.
1781-
'v8_enable_atomic_object_field_writes=0',
1782-
# Not available in gyp.
1783-
'v8_enable_concurrent_marking=0',
1778+
'v8_enable_atomic_marking_state=<(v8_enable_atomic_marking_state)',
1779+
'v8_enable_atomic_object_field_writes=<(v8_enable_atomic_object_field_writes)',
1780+
'v8_enable_concurrent_marking=<(v8_enable_concurrent_marking)',
17841781
'v8_enable_i18n_support=<(v8_enable_i18n_support)',
17851782
'v8_enable_verify_predictable=<(v8_enable_verify_predictable)',
17861783
'v8_enable_verify_csa=<(v8_enable_verify_csa)',

0 commit comments

Comments
 (0)