Skip to content

Commit c7f8a13

Browse files
aaynFishrock123
authored andcommitted
test: remove unneeded bind() and related comments
As mentioned in the comment of the changed file, "a libuv limitation makes it necessary to bind()". But, that is not the case in this test. The subsequent call to send() results in an implicit bind(). PR-URL: #5023 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
1 parent cc4cbb1 commit c7f8a13

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

test/internet/test-dgram-multicast-multi-process.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,6 @@ if (process.argv[2] !== 'child') {
132132
}
133133

134134
var sendSocket = dgram.createSocket('udp4');
135-
// FIXME: a libuv limitation makes it necessary to bind()
136-
// before calling any of the set*() functions. The bind()
137-
// call is what creates the actual socket.
138-
sendSocket.bind();
139135

140136
// The socket is actually created async now.
141137
sendSocket.on('listening', function() {

0 commit comments

Comments
 (0)