Skip to content

Commit c72585b

Browse files
TrottMylesBorins
authored andcommitted
test: fix flaky test-http2-reset-flood
Set `allowHalfOpen: true` in the client. Fixes: #29802 Refs: #31806 PR-URL: #34318 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Robert Nagy <ronagy@icloud.com>
1 parent ea35cc3 commit c72585b

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

test/parallel/parallel.status

-4
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ prefix parallel
55
# sample-test : PASS,FLAKY
66

77
[true] # This section applies to all platforms
8-
# https://github.com/nodejs/node/issues/29802
9-
test-http2-reset-flood: PASS,FLAKY
108

119
[$system==win32]
1210
# https://github.com/nodejs/node/issues/32863
@@ -48,8 +46,6 @@ test-fs-stream-construct: PASS,FLAKY
4846
[$system==freebsd]
4947
# https://github.com/nodejs/node/issues/31727
5048
test-fs-stat-bigint: PASS,FLAKY
51-
# https://github.com/nodejs/node/issues/29802
52-
test-http2-reset-flood: PASS,FLAKY
5349
# https://github.com/nodejs/node/issues/28803
5450
test-stdout-close-catch: PASS,FLAKY
5551
# https://github.com/nodejs/node/issues/31280

test/parallel/test-http2-reset-flood.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ if (process.env.HAS_STARTED_WORKER) {
2828
process.env.HAS_STARTED_WORKER = 1;
2929
const worker = new Worker(__filename).on('message', common.mustCall((port) => {
3030
const h2header = Buffer.alloc(9);
31-
const conn = net.connect(port);
31+
const conn = net.connect({ port, allowHalfOpen: true });
3232

3333
conn.write('PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n');
3434

0 commit comments

Comments
 (0)