Skip to content

Commit c721d44

Browse files
committed
src: remove usages of GetBackingStore in WASI
This removes all usages of GetBackingStore in WASI. See the linked issue for an explanation. Refs: #32226 Refs: #43921
1 parent 07d7e1b commit c721d44

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

src/node_wasi.cc

+3-5
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ inline void Debug(WASI* wasi, Args&&... args) {
7373
} while (0)
7474

7575
using v8::Array;
76-
using v8::BackingStore;
7776
using v8::BigInt;
7877
using v8::Context;
7978
using v8::Exception;
@@ -1654,10 +1653,9 @@ void WASI::_SetMemory(const FunctionCallbackInfo<Value>& args) {
16541653

16551654
uvwasi_errno_t WASI::backingStore(char** store, size_t* byte_length) {
16561655
Local<WasmMemoryObject> memory = PersistentToLocal::Strong(this->memory_);
1657-
std::shared_ptr<BackingStore> backing_store =
1658-
memory->Buffer()->GetBackingStore();
1659-
*byte_length = backing_store->ByteLength();
1660-
*store = static_cast<char*>(backing_store->Data());
1656+
Local<v8::ArrayBuffer> ab = memory->Buffer();
1657+
*byte_length = ab->ByteLength();
1658+
*store = static_cast<char*>(ab->Data());
16611659
CHECK_NOT_NULL(*store);
16621660
return UVWASI_ESUCCESS;
16631661
}

src/node_wasm_web_api.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -105,12 +105,12 @@ void WasmStreamingObject::Push(const FunctionCallbackInfo<Value>& args) {
105105

106106
if (LIKELY(chunk->IsArrayBufferView())) {
107107
Local<ArrayBufferView> view = chunk.As<ArrayBufferView>();
108-
bytes = view->Buffer()->GetBackingStore()->Data();
108+
bytes = view->Buffer()->Data();
109109
offset = view->ByteOffset();
110110
size = view->ByteLength();
111111
} else if (LIKELY(chunk->IsArrayBuffer())) {
112112
Local<ArrayBuffer> buffer = chunk.As<ArrayBuffer>();
113-
bytes = buffer->GetBackingStore()->Data();
113+
bytes = buffer->Data();
114114
offset = 0;
115115
size = buffer->ByteLength();
116116
} else {

0 commit comments

Comments
 (0)