Skip to content

Commit

Permalink
test: adapt test-worker-debug for V8 10.0
Browse files Browse the repository at this point in the history
V8 is removing callFrame.url.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/3345001

PR-URL: #42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
  • Loading branch information
targos committed Apr 12, 2022
1 parent 0854fce commit c6b4e96
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions test/parallel/test-worker-debug.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ common.skipIfInspectorDisabled();
const assert = require('assert');
const EventEmitter = require('events');
const { Session } = require('inspector');
const { pathToFileURL } = require('url');
const {
Worker, isMainThread, parentPort, workerData
} = require('worker_threads');
Expand Down Expand Up @@ -106,7 +105,6 @@ class WorkerSession extends EventEmitter {
this.post(command);
const notification = await notificationPromise;
const callFrame = notification.params.callFrames[0];
assert.strictEqual(callFrame.url, pathToFileURL(script).toString());
assert.strictEqual(callFrame.location.lineNumber, line);
}

Expand Down Expand Up @@ -153,7 +151,7 @@ async function testBasicWorkerDebug(session, post) {
await workerSession.waitForBreakAfterCommand(
'Runtime.runIfWaitingForDebugger', __filename, 1);
await workerSession.waitForBreakAfterCommand(
'Debugger.resume', __filename, 26); // V8 line number is zero-based
'Debugger.resume', __filename, 25); // V8 line number is zero-based
const msg = await consolePromise;
assert.strictEqual(msg, workerMessage);
workerSession.post('Debugger.resume');
Expand Down

0 comments on commit c6b4e96

Please sign in to comment.