Skip to content

Commit c5928ab

Browse files
committed
build: make lint-ci work properly on Linux make
PR-URL: #19746 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
1 parent 67bbc84 commit c5928ab

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Makefile

+3-2
Original file line numberDiff line numberDiff line change
@@ -1133,7 +1133,8 @@ lint-js-ci:
11331133
jslint-ci: lint-js-ci
11341134
@echo "Please use lint-js-ci instead of jslint-ci"
11351135

1136-
LINT_CPP_ADDON_DOC_FILES = $(wildcard test/addons/??_*/*.cc test/addons/??_*/*.h)
1136+
LINT_CPP_ADDON_DOC_FILES_GLOB = test/addons/??_*/*.cc test/addons/??_*/*.h
1137+
LINT_CPP_ADDON_DOC_FILES = $(wildcard $(LINT_CPP_ADDON_DOC_FILES_GLOB))
11371138
LINT_CPP_EXCLUDE ?=
11381139
LINT_CPP_EXCLUDE += src/node_root_certs.h
11391140
LINT_CPP_EXCLUDE += $(LINT_CPP_ADDON_DOC_FILES)
@@ -1176,7 +1177,7 @@ tools/.cpplintstamp: $(LINT_CPP_FILES)
11761177

11771178
lint-addon-docs: test/addons/.docbuildstamp
11781179
@echo "Running C++ linter on addon docs..."
1179-
@$(PYTHON) tools/cpplint.py --filter=$(ADDON_DOC_LINT_FLAGS) $(LINT_CPP_ADDON_DOC_FILES)
1180+
@$(PYTHON) tools/cpplint.py --filter=$(ADDON_DOC_LINT_FLAGS) $(LINT_CPP_ADDON_DOC_FILES_GLOB)
11801181

11811182
cpplint: lint-cpp
11821183
@echo "Please use lint-cpp instead of cpplint"

0 commit comments

Comments
 (0)