Skip to content

Commit c420cd1

Browse files
committed
test: support candidate V8 versions
When V8 is built from its master branch, it adds a " (candidate)" suffix to the version string. Add support for that in the tests so it does not fail with Node canary. PR-URL: #13282 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
1 parent 1091327 commit c420cd1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/parallel/test-process-versions.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@ assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.http_parser));
2626
assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.node));
2727
assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.uv));
2828
assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.zlib));
29-
assert(/^\d+\.\d+\.\d+(\.\d+)?$/.test(process.versions.v8));
29+
assert(/^\d+\.\d+\.\d+(\.\d+)?( \(candidate\))?$/.test(process.versions.v8));
3030
assert(/^\d+$/.test(process.versions.modules));

0 commit comments

Comments
 (0)