Skip to content

Commit c41facb

Browse files
Aditi-1400aduh95
authored andcommitted
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
Refs: #57578 PR-URL: #57733 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
1 parent 085340f commit c41facb

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/node_messaging.cc

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ using v8::Isolate;
2727
using v8::Just;
2828
using v8::JustVoid;
2929
using v8::Local;
30+
using v8::LocalVector;
3031
using v8::Maybe;
3132
using v8::MaybeLocal;
3233
using v8::Nothing;
@@ -74,7 +75,7 @@ class DeserializerDelegate : public ValueDeserializer::Delegate {
7475
Message* m,
7576
Environment* env,
7677
const std::vector<BaseObjectPtr<BaseObject>>& host_objects,
77-
const std::vector<Local<SharedArrayBuffer>>& shared_array_buffers,
78+
const LocalVector<SharedArrayBuffer>& shared_array_buffers,
7879
const std::vector<CompiledWasmModule>& wasm_modules,
7980
const std::optional<SharedValueConveyor>& shared_value_conveyor)
8081
: env_(env),
@@ -129,7 +130,7 @@ class DeserializerDelegate : public ValueDeserializer::Delegate {
129130
private:
130131
Environment* env_;
131132
const std::vector<BaseObjectPtr<BaseObject>>& host_objects_;
132-
const std::vector<Local<SharedArrayBuffer>>& shared_array_buffers_;
133+
const LocalVector<SharedArrayBuffer>& shared_array_buffers_;
133134
const std::vector<CompiledWasmModule>& wasm_modules_;
134135
const std::optional<SharedValueConveyor>& shared_value_conveyor_;
135136
};
@@ -188,7 +189,7 @@ MaybeLocal<Value> Message::Deserialize(Environment* env,
188189
}
189190
transferables_.clear();
190191

191-
std::vector<Local<SharedArrayBuffer>> shared_array_buffers;
192+
LocalVector<SharedArrayBuffer> shared_array_buffers(env->isolate());
192193
// Attach all transferred SharedArrayBuffers to their new Isolate.
193194
for (uint32_t i = 0; i < shared_array_buffers_.size(); ++i) {
194195
Local<SharedArrayBuffer> sab =
@@ -477,7 +478,7 @@ Maybe<bool> Message::Serialize(Environment* env,
477478
ValueSerializer serializer(env->isolate(), &delegate);
478479
delegate.serializer = &serializer;
479480

480-
std::vector<Local<ArrayBuffer>> array_buffers;
481+
LocalVector<ArrayBuffer> array_buffers(env->isolate());
481482
for (uint32_t i = 0; i < transfer_list_v.length(); ++i) {
482483
Local<Value> entry_val = transfer_list_v[i];
483484
if (!entry_val->IsObject()) {
@@ -998,7 +999,7 @@ static Maybe<bool> ReadIterable(Environment* env,
998999
return Nothing<bool>();
9991000
if (!next->IsFunction()) return Just(false);
10001001

1001-
std::vector<Local<Value>> entries;
1002+
LocalVector<Value> entries(isolate);
10021003
while (env->can_call_into_js()) {
10031004
Local<Value> result;
10041005
if (!next.As<Function>()->Call(context, iterator, 0, nullptr)

0 commit comments

Comments
 (0)