Skip to content

Commit c41525a

Browse files
JonasBaaduh95
authored andcommitted
src: add dcheck_eq for Object::New constructor calls
PR-URL: #57943 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 727ce28 commit c41525a

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/node_sqlite.cc

+8
Original file line numberDiff line numberDiff line change
@@ -1997,6 +1997,7 @@ void StatementSync::All(const FunctionCallbackInfo<Value>& args) {
19971997
row_values.emplace_back(val);
19981998
}
19991999

2000+
DCHECK_EQ(row_keys.size(), row_values.size());
20002001
Local<Object> row_obj = Object::New(
20012002
isolate, Null(isolate), row_keys.data(), row_values.data(), num_cols);
20022003
rows.emplace_back(row_obj);
@@ -2101,6 +2102,7 @@ void StatementSync::Get(const FunctionCallbackInfo<Value>& args) {
21012102
values.emplace_back(val);
21022103
}
21032104

2105+
DCHECK_EQ(keys.size(), values.size());
21042106
Local<Object> result = Object::New(
21052107
isolate, Null(isolate), keys.data(), values.data(), num_cols);
21062108

@@ -2449,6 +2451,7 @@ void StatementSyncIterator::Next(const FunctionCallbackInfo<Value>& args) {
24492451
if (iter->done_) {
24502452
LocalVector<Value> values(isolate,
24512453
{Boolean::New(isolate, true), Null(isolate)});
2454+
DCHECK_EQ(values.size(), keys.size());
24522455
Local<Object> result = Object::New(
24532456
isolate, Null(isolate), keys.data(), values.data(), keys.size());
24542457
args.GetReturnValue().Set(result);
@@ -2462,6 +2465,7 @@ void StatementSyncIterator::Next(const FunctionCallbackInfo<Value>& args) {
24622465
sqlite3_reset(iter->stmt_->statement_);
24632466
LocalVector<Value> values(isolate,
24642467
{Boolean::New(isolate, true), Null(isolate)});
2468+
DCHECK_EQ(values.size(), keys.size());
24652469
Local<Object> result = Object::New(
24662470
isolate, Null(isolate), keys.data(), values.data(), keys.size());
24672471
args.GetReturnValue().Set(result);
@@ -2494,11 +2498,13 @@ void StatementSyncIterator::Next(const FunctionCallbackInfo<Value>& args) {
24942498
row_values.emplace_back(val);
24952499
}
24962500

2501+
DCHECK_EQ(row_keys.size(), row_values.size());
24972502
row_value = Object::New(
24982503
isolate, Null(isolate), row_keys.data(), row_values.data(), num_cols);
24992504
}
25002505

25012506
LocalVector<Value> values(isolate, {Boolean::New(isolate, false), row_value});
2507+
DCHECK_EQ(keys.size(), values.size());
25022508
Local<Object> result = Object::New(
25032509
isolate, Null(isolate), keys.data(), values.data(), keys.size());
25042510
args.GetReturnValue().Set(result);
@@ -2517,6 +2523,8 @@ void StatementSyncIterator::Return(const FunctionCallbackInfo<Value>& args) {
25172523
LocalVector<Name> keys(isolate, {env->done_string(), env->value_string()});
25182524
LocalVector<Value> values(isolate,
25192525
{Boolean::New(isolate, true), Null(isolate)});
2526+
2527+
DCHECK_EQ(keys.size(), values.size());
25202528
Local<Object> result = Object::New(
25212529
isolate, Null(isolate), keys.data(), values.data(), keys.size());
25222530
args.GetReturnValue().Set(result);

0 commit comments

Comments
 (0)