From c28ec86c90eaaf547036945faff344bab375aef3 Mon Sep 17 00:00:00 2001 From: Maya Anilson Date: Sat, 17 Nov 2018 17:59:15 +0530 Subject: [PATCH] test: replace closure with arrow function PR-URL: https://github.com/nodejs/node/pull/24489 Reviewed-By: Franziska Hinkelmann Reviewed-By: James M Snell Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Colin Ihrig Reviewed-By: Gireesh Punathil Reviewed-By: Ruben Bridgewater --- test/pummel/test-net-timeout.js | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/test/pummel/test-net-timeout.js b/test/pummel/test-net-timeout.js index e87cdc0b8edf51..524322440a1ea6 100644 --- a/test/pummel/test-net-timeout.js +++ b/test/pummel/test-net-timeout.js @@ -29,46 +29,46 @@ let starttime = null; let timeouttime = null; const timeout = 1000; -const echo_server = net.createServer(function(socket) { +const echo_server = net.createServer((socket) => { socket.setTimeout(timeout); - socket.on('timeout', function() { + socket.on('timeout', () => { console.log('server timeout'); timeouttime = new Date(); console.dir(timeouttime); socket.destroy(); }); - socket.on('error', function(e) { + socket.on('error', (e) => { throw new Error( 'Server side socket should not get error. We disconnect willingly.'); }); - socket.on('data', function(d) { + socket.on('data', (d) => { console.log(d); socket.write(d); }); - socket.on('end', function() { + socket.on('end', () => { socket.end(); }); }); -echo_server.listen(common.PORT, function() { +echo_server.listen(common.PORT, () => { console.log(`server listening at ${common.PORT}`); const client = net.createConnection(common.PORT); client.setEncoding('UTF8'); client.setTimeout(0); // disable the timeout for client - client.on('connect', function() { + client.on('connect', () => { console.log('client connected.'); client.write('hello\r\n'); }); - client.on('data', function(chunk) { + client.on('data', (chunk) => { assert.strictEqual(chunk, 'hello\r\n'); if (exchanges++ < 5) { - setTimeout(function() { + setTimeout(() => { console.log('client write "hello"'); client.write('hello\r\n'); }, 500); @@ -81,22 +81,22 @@ echo_server.listen(common.PORT, function() { } }); - client.on('timeout', function() { + client.on('timeout', () => { throw new Error("client timeout - this shouldn't happen"); }); - client.on('end', function() { + client.on('end', () => { console.log('client end'); client.end(); }); - client.on('close', function() { + client.on('close', () => { console.log('client disconnect'); echo_server.close(); }); }); -process.on('exit', function() { +process.on('exit', () => { assert.ok(starttime != null); assert.ok(timeouttime != null);