lib: fix undefined timeout regression

63644dd introduced a regression caused by everyone's favourite JavaScript feature: undefined < 0 === undefined >= 0. Add a case to the existing tests to cover this scenario and then add the check for undefined that makes the test pass. PR-URL: #3331 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed By: Evan Lucas <evanlucas@me.com>
nodejs · Oct 13, 2015 · c245a19 · c245a19
1 parent b3cbd13
commit c245a19
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/timers.js b/lib/timers.js
@@ -30,7 +30,7 @@ var lists = {};
 // with them.
 exports.active = function(item) {
   const msecs = item._idleTimeout;
-  if (msecs < 0) return;
+  if (msecs < 0 || msecs === undefined) return;
 
   item._idleStart = Timer.now();
 

diff --git a/test/parallel/test-timers-active.js b/test/parallel/test-timers-active.js
@@ -22,7 +22,8 @@ legitTimers.forEach(function(legit) {
 
 // active() should not create a timer for these
 var bogusTimers = [
-  { _idleTimeout: -1 }
+  { _idleTimeout: -1 },
+  { _idleTimeout: undefined },
 ];
 
 bogusTimers.forEach(function(bogus) {