Skip to content

Commit

Permalink
doc: remove outdated step in onboarding exercise
Browse files Browse the repository at this point in the history
The GitHub bot will leave a comment asking people to thumbs-up a fast
track request so there is no need to manually leave such a comment.

PR-URL: #39410
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott authored and jasnell committed Jul 19, 2021
1 parent 057e31d commit c154c6c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions onboarding.md
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,12 @@ needs to be pointed out separately during the onboarding.
so that when the commit lands, the nomination issue url will be
automatically closed.
* Label your pull request with the `doc`, `notable-change`, and `fast-track`
labels.
labels. The `fast-track` label should cause the Node.js GitHub bot to post a
comment in the pull request asking collaborators to approve the pull request
by leaving a 👍 reaction on the comment.
* Run CI on the pull request. Use the `node-test-pull-request` CI task.
* After two Collaborator approvals for the change and two Collaborator approvals
for fast-tracking, land the pull request.
* Leave a comment in the pull request:
`Please 👍 this comment to approve fast-tracking`.
for fast-tracking, land the PR.
* If there are not enough approvals within a reasonable time, consider the
single approval of the onboarding TSC member sufficient, and land the pull
request.
Expand Down

0 comments on commit c154c6c

Please sign in to comment.