Skip to content

Commit bf9e17e

Browse files
joyeecheungaduh95
authored andcommitted
http2: use args.This() instead of args.Holder()
args.Holder() has been removed in newer version of V8. PR-URL: #58004 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent b0256dd commit bf9e17e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/node_http2.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -770,7 +770,7 @@ void Http2Stream::EmitStatistics() {
770770

771771
void Http2Session::HasPendingData(const FunctionCallbackInfo<Value>& args) {
772772
Http2Session* session;
773-
ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder());
773+
ASSIGN_OR_RETURN_UNWRAP(&session, args.This());
774774
args.GetReturnValue().Set(session->HasPendingData());
775775
}
776776

@@ -3580,7 +3580,7 @@ void Initialize(Local<Object> target,
35803580

35813581
void Http2Session::SetGracefulClose(const FunctionCallbackInfo<Value>& args) {
35823582
Http2Session* session;
3583-
ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder());
3583+
ASSIGN_OR_RETURN_UNWRAP(&session, args.This());
35843584
CHECK_NOT_NULL(session);
35853585
// Set the graceful close flag
35863586
session->SetGracefulCloseInitiated(true);

0 commit comments

Comments
 (0)